run go fix ./... (#836)

Author: brainexe

.golangci.yml

@@ -58,6 +58,9 @@ linters:
       - linters:
           - tagalign
         path: bot/config/
+      - linters:
+          - gochecknoinits
+        path: plugins/
     paths:
       - third_party$
       - builtin$

AGENTS.md

@@ -4,7 +4,7 @@
 
 This is a **Slack Bot** written in **Go** that improves development team workflows with integrations for Jenkins, GitHub, GitLab, and Jira. The bot supports custom commands, macros, cron jobs, and flexible project-specific functionality.
 
-- **Language**: Go (requires Go 1.24+)
+- **Language**: Go (requires Go 1.25+)
 - **Type**: Slack application with Socket Mode support
 - **Size**: ~50+ Go packages across bot/, command/, client/, and cmd/ directories
 - **Architecture**: Modular command-based bot with plugin system
@@ -13,7 +13,7 @@ This is a **Slack Bot** written in **Go** that improves development team workflo
 ## Build and Validation Instructions
 
 ### Prerequisites
-- **Go 1.24 or later**
+- **Go 1.25 or later**
 - **Make** (for build targets)
 - **Docker** (optional, for containerized builds)
 - **golangci-lint** (for linting)

Makefile

@@ -31,6 +31,7 @@ dep:
 	@go mod vendor
 
 lint:
+	go fix ./...
 	golangci-lint run --fix
 
 docker-build:

bot/bot_handle.go

@@ -101,18 +101,16 @@ func (b *Bot) ProcessMessage(message msg.Message, fromUserContext bool) {
 
 		logger.Errorf("user %s (%s) is not allowed to execute message (authentication is active and user is missing in 'allowed_users' section): %s", userName, message.User, message.Text)
 
-		errorMessage := "Sorry, you are not whitelisted in the config yet."
+		var errorMessage strings.Builder
+		errorMessage.WriteString("Sorry, you are not whitelisted in the config yet.")
 		if len(b.config.AdminUsers) > 0 {
-			errorMessage += " Please ask a slack-bot admin to get access: "
+			errorMessage.WriteString(" Please ask a slack-bot admin to get access: ")
 			for _, admin := range b.config.AdminUsers {
 				adminID, _ := client.GetUserIDAndName(admin)
-				errorMessage += fmt.Sprintf(
-					" <@%s>",
-					adminID,
-				)
+				fmt.Fprintf(&errorMessage, " <@%s>", adminID)
 			}
 		}
-		b.slackClient.SendEphemeralMessage(message, errorMessage)
+		b.slackClient.SendEphemeralMessage(message, errorMessage.String())
 		b.slackClient.AddReaction("❌", message)
 
 		stats.IncreaseOne(stats.UnauthorizedCommands)

bot/config/config.go

@@ -3,6 +3,8 @@
 package config
 
 import (
+	"slices"
+
 	"github.com/brainexe/viper"
 )
 
@@ -129,13 +131,7 @@ type UserList []string
 
 // Contains checks if the given user is in the UserList
 func (l UserList) Contains(givenUserID string) bool {
-	for _, userID := range l {
-		if userID == givenUserID {
-			return true
-		}
-	}
-
-	return false
+	return slices.Contains(l, givenUserID)
 }
 
 // UserMap indexed by user id, value is the user name

bot/interaction.go

@@ -60,7 +60,7 @@ func (b *Bot) handleEvent(eventsAPIEvent slackevents.EventsAPIEvent) {
 }
 
 func (b *Bot) loadFileContent(event *slackevents.MessageEvent) string {
-	response := ""
+	var response strings.Builder
 
 	for _, file := range event.Message.Files {
 		if !strings.HasPrefix(file.Mimetype, "text/") {
@@ -77,10 +77,10 @@ func (b *Bot) loadFileContent(event *slackevents.MessageEvent) string {
 			continue
 		}
 
-		response += "\n" + downloadedText.String()
+		response.WriteString("\n" + downloadedText.String())
 	}
 
-	return response
+	return response.String()
 }
 
 func (b *Bot) handleInteraction(payload slack.InteractionCallback) bool {
@@ -91,7 +91,7 @@ func (b *Bot) handleInteraction(payload slack.InteractionCallback) bool {
 	stats.IncreaseOne(stats.Interactions)
 
 	switch payload.Type {
-	case "block_actions":
+	case slack.InteractionTypeBlockActions:
 		// user clicked on one of our interactive buttons
 		action := payload.ActionCallback.BlockActions[0]
 		command := action.Value
@@ -133,10 +133,25 @@ func (b *Bot) handleInteraction(payload slack.InteractionCallback) bool {
 
 		// execute the command which is stored for this interaction
 		go b.ProcessMessage(ref.WithText(command), true)
-	case "message_action":
+	case slack.InteractionTypeMessageAction:
 		// todo implement interactive slack messages (right click menu)
 		log.Warnf("Received unhandled message action: %+v", payload)
 		return true
+	case slack.InteractionTypeDialogCancellation,
+		slack.InteractionTypeDialogSubmission,
+		slack.InteractionTypeDialogSuggestion,
+		slack.InteractionTypeInteractionMessage,
+		slack.InteractionTypeBlockSuggestion,
+		slack.InteractionTypeViewSubmission,
+		slack.InteractionTypeViewClosed,
+		slack.InteractionTypeShortcut,
+		slack.InteractionTypeWorkflowStepEdit:
+		// These interaction types are not currently handled by this bot
+		log.Infof("Received unhandled interaction type: %s", payload.Type)
+		return false
+	default:
+		log.Warnf("Received unknown interaction type: %s", payload.Type)
+		return false
 	}
 
 	return true

bot/tester/tester.go

@@ -7,6 +7,7 @@ import (
 	"io"
 	"net/http"
 	"net/url"
+	"strings"
 
 	"github.com/gookit/color"
 	"github.com/innogames/slack-bot/v2/bot"
@@ -80,32 +81,40 @@ func messageHandler(w http.ResponseWriter, r *http.Request, output io.Writer) {
 		var blocks []map[string]any
 		_ = json.Unmarshal([]byte(blockJSON), &blocks)
 
+		var blockText strings.Builder
 		for _, block := range blocks {
-			text += formatBlock(block) + "\n"
+			blockText.WriteString(formatBlock(block) + "\n")
 		}
+		text += blockText.String()
 	} else if text == "" && query.Get("attachments") != "" {
 		attachmentJSON := query.Get("attachments")
 		var attachments []map[string]any
 		_ = json.Unmarshal([]byte(attachmentJSON), &attachments)
 
+		var attachmentTitles strings.Builder
+		var attachmentActions strings.Builder
 		for _, attachment := range attachments {
 			if txt, ok := attachment["title"].(string); ok {
-				text += txt + "\n"
+				attachmentTitles.WriteString(txt + "\n")
 			}
+			var actionText strings.Builder
 			for _, action := range attachment["actions"].([]any) {
 				actionMap := action.(map[string]any)
 
 				if actionMap["type"] == "button" {
-					text += fmt.Sprintf(
+					fmt.Fprintf(&actionText,
 						"<%s|%s>\n",
 						actionMap["url"],
 						actionMap["text"],
 					)
 				} else {
-					text += fmt.Sprintf("Attachment-actions are not supported yet:\n%v\n", action)
+					fmt.Fprintf(&actionText, "Attachment-actions are not supported yet:\n%v\n", action)
 				}
 			}
+			attachmentActions.WriteString(actionText.String())
 		}
+		text += attachmentActions.String()
+		text += attachmentTitles.String()
 	}
 
 	_, _ = fmt.Fprint(output, formatSlackMessage(text)+"\n")
@@ -139,11 +148,11 @@ func formatBlock(block map[string]any) string {
 // bit hacky way to extract the text from some kind of block element
 func extractText(block map[string]any) string {
 	if fields, ok := block["fields"]; ok {
-		result := ""
+		var result strings.Builder
 		for _, field := range fields.([]any) {
-			result += extractText(field.(map[string]any))
+			result.WriteString(extractText(field.(map[string]any)))
 		}
-		return result
+		return result.String()
 	}
 
 	// contains "text" element

bot/util/template.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
+	"maps"
 	"text/template"
 	"time"
 )
@@ -60,9 +61,7 @@ func GetTemplateFunctions() template.FuncMap {
 
 // RegisterFunctions will add a function to any template renderer
 func RegisterFunctions(funcMap template.FuncMap) {
-	for name, function := range funcMap {
-		functions[name] = function
-	}
+	maps.Copy(functions, funcMap)
 }
 
 // CompileTemplate pre compiles a template and returns an error if an function is not available etc

cmd/bot/pprof.go

@@ -1,5 +1,4 @@
 //go:build pprof
-// +build pprof
 
 package main
 

command/admin/bot_log.go

@@ -70,10 +70,7 @@ func (c *botLogCommand) readFile(filename string, chars int64) []byte {
 	defer file.Close()
 
 	stat, _ := os.Stat(filename)
-	start := stat.Size() - chars
-	if start < 0 {
-		start = 0
-	}
+	start := max(stat.Size()-chars, 0)
 
 	_, err = file.ReadAt(buf, start)
 	if err != nil && err.Error() != "EOF" {