Skip to content

Dependency information mention #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catskul opened this issue Mar 10, 2015 · 1 comment
Closed

Dependency information mention #2

catskul opened this issue Mar 10, 2015 · 1 comment

Comments

@catskul
Copy link

catskul commented Mar 10, 2015

This is probably moot if using npm, but relevant otherwise.

The library has a few dependencies that should probably be called out in the readme. The one that caught me was react-with-addons-0.12.2.min.js as I'd been using react-0.12.2.js and getting errors.

(Awesome library by the way!)
@insin
Copy link
Owner

insin commented Mar 10, 2015

Will do, thanks for the report.

This requirement will go away with React 0.13 as it brings React.cloneElement to the top-level API. The current cloning approach should go away entirely when facebook/react#2112 lands.

@insin insin closed this as completed in e3788a4 Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@insin @catskul