Merge pull request #52 from ChanderG/bugfix-large-datapoints

bugfix: remove out large samples from the multi pack batch sampler

Author: aldopareja

src/instructlab/training/multipack_sampler.py

@@ -437,6 +437,11 @@ def generate_batches(self, set_stats=False):
             len(self.lengths)
         )
 
+        # remove indices where the entries are longer than batch max length
+        indices = indices[self.lengths[indices] <= self.batch_max_length]
+        if len(indices) < len(self.lengths):
+            print(f"\033[33mDropping {len(self.lengths) - len(indices)} samples longer than batch_max_length. Ensure that the right max_batch_length is used during data processing.\033[0m")
+
         lengths = self.lengths[indices]
         lengths_cumsum = np.cumsum(lengths)