Skip to content

Commit 07d3afa

Browse files
wpangfxbot
authored andcommitted
Do not build schedulers as a library as it is not a useful standalone
library. This removes circular dependencies while creating dlls Change-Id: I9276f43cca4c744fe6a3316b13aae7e5d8607920
1 parent 3bb520c commit 07d3afa

File tree

4 files changed

+21
-133
lines changed

4 files changed

+21
-133
lines changed

IGC/CMakeLists.txt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3421,8 +3421,6 @@ set(IGC_BUILD__PROJ_LABEL__igc_lib "${IGC_BUILD__PROJ__igc_lib}")
34213421

34223422
set(IGC_BUILD__PROJ_LABEL__GenX_IR "${IGC_BUILD__PROJ_NAME_PREFIX}vISA")
34233423

3424-
set(IGC_BUILD__PROJ_LABEL__LocalScheduler "${IGC_BUILD__PROJ_NAME_PREFIX}LocalScheduler")
3425-
34263424
add_subdirectory(common)
34273425
igc_sg_define(IGC__common)
34283426
igc_sg_define(IGC__Common_CLElfLib)
@@ -3637,11 +3635,10 @@ unset(_cpuSuffix)
36373635

36383636
# Injecting external vISA project.
36393637
add_subdirectory("${IGC_BUILD__VISA_DIR}" visa)
3640-
set_property(TARGET "GenX_IR" "LocalScheduler" APPEND PROPERTY COMPILE_DEFINITIONS
3638+
set_property(TARGET "GenX_IR" APPEND PROPERTY COMPILE_DEFINITIONS
36413639
${IGC_BUID__VISA_COMPILE_DEFINITIONS}
36423640
)
3643-
set_property(TARGET "GenX_IR" PROPERTY PROJECT_LABEL "${IGC_BUILD__PROJ_LABEL__GenX_IR}")
3644-
set_property(TARGET "LocalScheduler" PROPERTY PROJECT_LABEL "${IGC_BUILD__PROJ_LABEL__LocalScheduler}")
3641+
set_property(TARGET "GenX_IR" PROPERTY PROJECT_LABEL "${IGC_BUILD__PROJ_LABEL__GenX_IR}")
36453642

36463643

36473644
# =================================== Link targets and dependencies ====================================

visa/CMakeLists.txt

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,6 @@ if (IGC_BUILD)
7373

7474
endif (IGC_BUILD)
7575

76-
# Common library used by the shared libraries in this file (a sub directory of this directory hence
77-
# invoked from here)
78-
add_subdirectory(LocalScheduler)
79-
8076
if(BS_USE_OSDM_BUILD_SYSTEM)
8177
include(${BUILD_SYS_INC}/utils.cmake)
8278
# Locate bison and flex using common bs macro
@@ -159,6 +155,19 @@ include_directories(${Jitter_inc_dirs})
159155
# (due to the fact that they are .c files rather than .cpp)
160156
set_source_files_properties( CISA.tab.c lex.CISA.c PROPERTIES LANGUAGE CXX )
161157

158+
set(LocalScheduler_SOURCES
159+
LocalScheduler/Dependencies_G4IR.cpp
160+
LocalScheduler/G4_Sched.cpp
161+
LocalScheduler/LatencyTable.cpp
162+
LocalScheduler/LocalScheduler_G4IR.cpp
163+
)
164+
165+
set(LocalScheduler_HEADERS
166+
LocalScheduler/Dependencies_G4IR.h
167+
LocalScheduler/LatencyTable.h
168+
LocalScheduler/LocalScheduler_G4IR.h
169+
)
170+
162171
# Set up some common source files used in all the projects so they only need to be defined once
163172
set(GenX_Common_Sources_External
164173
BinaryCISAEmission.cpp
@@ -196,6 +205,7 @@ set(GenX_Common_Sources_External
196205
SpillCleanup.cpp
197206
Rematerialization.cpp
198207
RPE.cpp
208+
${LocalScheduler_SOURCES}
199209
)
200210

201211
set(GenX_Common_Sources
@@ -275,6 +285,7 @@ set(GenX_Common_Headers
275285
Metadata.h
276286
RPE.h
277287
include/gtpin_IGC_interface.h
288+
${LocalScheduler_HEADERS}
278289
)
279290
set(GenX_CISA_dis_Common_Headers
280291
common.h
@@ -340,7 +351,7 @@ if (UNIX OR WIN32)
340351
source_group("Utility Files" FILES ${GenX_IR_EXE_UTILITY} )
341352
source_group("Header Files" FILES ${GenX_IR_EXE_HEADERS} )
342353
source_group("Lex Yacc Files" FILES ${GenX_IR_EXE_lex_yacc} )
343-
target_link_libraries(GenX_IR_Exe LocalScheduler IGA_SLIB IGA_ENC_LIB)
354+
target_link_libraries(GenX_IR_Exe IGA_SLIB IGA_ENC_LIB)
344355
if (ANDROID AND MEDIA_IGA)
345356
target_link_libraries(GenX_IR_Exe c++_static)
346357
endif(ANDROID AND MEDIA_IGA)
@@ -405,7 +416,7 @@ endif (NOT IGC_BUILD)
405416
# ###############################################################
406417
# GenX_IR (dll)
407418
# ###############################################################
408-
link_directories(${libGenX_IR_BINARY_DIR}/LocalScheduler)
419+
409420
set(GenX_IR_DLL_SOURCES
410421
${GenX_Common_Sources}
411422
${GenX_CISA_dis_Common_Sources}
@@ -449,10 +460,10 @@ if (IGC_BUILD)
449460
)
450461
set_target_properties( GenX_IR PROPERTIES OUTPUT_NAME "igfxcmjit${TARGET_MODIFIER}")
451462
if(WIN32)
452-
target_link_libraries(GenX_IR LocalScheduler ${GCC_SECURE_LINK_FLAGS} IGA_ENC_LIB IGA_SLIB)
463+
target_link_libraries(GenX_IR ${GCC_SECURE_LINK_FLAGS} IGA_ENC_LIB IGA_SLIB)
453464
add_dependencies(GenX_IR IGA_DLL)
454465
else()
455-
target_link_libraries(GenX_IR LocalScheduler ${GCC_SECURE_LINK_FLAGS} IGA_ENC_LIB IGA_SLIB)
466+
target_link_libraries(GenX_IR ${GCC_SECURE_LINK_FLAGS} IGA_ENC_LIB IGA_SLIB)
456467
add_dependencies(GenX_IR IGA_DLL)
457468
endif(WIN32)
458469
endif (IGC_BUILD)

visa/LocalScheduler/CMakeLists.txt

Lines changed: 0 additions & 62 deletions
This file was deleted.

visa/LocalScheduler/SKL_latencies.def

Lines changed: 0 additions & 58 deletions
This file was deleted.

0 commit comments

Comments
 (0)