Skip to content

Commit 2710b53

Browse files
[SYCL][E2E] Fix LIT requires vulkan directive (#18348)
The addition of "vulkan" to `config.available_features` was moved to `bindless_images/lit.local.cfg` in #18220. This broke the `// REQUIRES: vulkan` directive, and tests were reporting as being unsupported despite vulkan being available on the system. This patch moves the check and addition of vulkan to the available features back to `test-e2e/lit.cfg.py` to fix the issue.
1 parent dc472b3 commit 2710b53

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

sycl/test-e2e/bindless_images/lit.local.cfg

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,3 @@ if platform.system() == "Windows":
2222
if cl_options:
2323
dx12libs = ['/clang:' + l for l in dx12libs]
2424
config.substitutions.append(("%link-directx", ' '.join(dx12libs)))
25-
26-
if config.vulkan_found == "TRUE":
27-
config.available_features.add("vulkan")

sycl/test-e2e/lit.cfg.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,10 @@ def open_check_file(file_name):
605605
else:
606606
config.substitutions.append(("%verbose_print", ""))
607607

608+
# Enable `vulkan` feature if Vulkan was found.
609+
if config.vulkan_found == "TRUE":
610+
config.available_features.add("vulkan")
611+
608612
if not config.gpu_aot_target_opts:
609613
config.gpu_aot_target_opts = '"-device *"'
610614

0 commit comments

Comments
 (0)