Skip to content

Commit ea75135

Browse files
committed
[SYCL][Graph] Remove calls to urCommandBufferReleaseCommandExp
Reflects UR change from oneapi-src/unified-runtime#2578 where we no longer need to manually manage the lifetimes of the individual commands in a UR command-buffer.
1 parent d70ed19 commit ea75135

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

sycl/cmake/modules/FetchUnifiedRuntime.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ if(SYCL_UR_USE_FETCH_CONTENT)
116116
CACHE PATH "Path to external '${name}' adapter source dir" FORCE)
117117
endfunction()
118118

119-
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
119+
set(UNIFIED_RUNTIME_REPO "https://github.com/Bensuo/unified-runtime.git")
120120
include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules/UnifiedRuntimeTag.cmake)
121121

122122
set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")

sycl/cmake/modules/UnifiedRuntimeTag.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
# Date: Thu Jan 16 14:30:47 2025 +0000
55
# Merge pull request #2569 from zhaomaosu/asan-only-warn-host-ptr
66
# [DevASAN] Only report warning if passing host ptr to kernel
7-
set(UNIFIED_RUNTIME_TAG eaea885d5477c8936209175a5b00062ca44f5765)
7+
set(UNIFIED_RUNTIME_TAG "ewan/remove_command_ref_counting")

sycl/source/detail/graph_impl.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -951,15 +951,6 @@ exec_graph_impl::~exec_graph_impl() {
951951
}
952952
}
953953
}
954-
955-
for (auto &Iter : MCommandMap) {
956-
if (auto Command = Iter.second; Command) {
957-
ur_result_t Res = Adapter->call_nocheck<
958-
sycl::detail::UrApiKind::urCommandBufferReleaseCommandExp>(Command);
959-
(void)Res;
960-
assert(Res == UR_RESULT_SUCCESS);
961-
}
962-
}
963954
} catch (std::exception &e) {
964955
__SYCL_REPORT_EXCEPTION_TO_STREAM("exception in ~exec_graph_impl", e);
965956
}

0 commit comments

Comments
 (0)