From 4bcd1e44809094115050350caf74be0a54ec67c8 Mon Sep 17 00:00:00 2001 From: "Larsen, Steffen" Date: Thu, 1 May 2025 08:58:01 -0700 Subject: [PATCH] [SYCL][E2E] Remove UB kernel launch in sycl_join This commit removes the explicit kernel launch in sycl_join, as the use of the set_args assumes the layout of arguments in the kernel, which is not guaranteed to be as expected. Signed-off-by: Larsen, Steffen --- sycl/test-e2e/KernelCompiler/sycl_join.cpp | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/sycl/test-e2e/KernelCompiler/sycl_join.cpp b/sycl/test-e2e/KernelCompiler/sycl_join.cpp index 99ad22396f7af..ecc5011dd0b83 100644 --- a/sycl/test-e2e/KernelCompiler/sycl_join.cpp +++ b/sycl/test-e2e/KernelCompiler/sycl_join.cpp @@ -210,25 +210,12 @@ int main() { ++Failed; } - Q.submit([&](sycl::handler &CGH) { - CGH.set_args(IntPtr); - CGH.single_task(RegularSYCLK); - }).wait_and_throw(); - - if (*IntPtr != RegularSYCLKernelWriteValue) { - std::cout << "Regular SYCL kernel (explicit) in joined mixed executable " - "bundles failed: " - << *IntPtr << " != " << RegularSYCLKernelWriteValue << "\n"; - ++Failed; - } - *IntPtr = 0; - RunRegularSYCLKernel(Q, KBExeJoined, IntPtr); if (*IntPtr != RegularSYCLKernelWriteValue) { - std::cout << "Regular SYCL kernel (implicit) in joined mixed executable " - "bundles failed: " - << *IntPtr << " != " << RegularSYCLKernelWriteValue << "\n"; + std::cout + << "Regular SYCL kernel in joined mixed executable bundles failed: " + << *IntPtr << " != " << RegularSYCLKernelWriteValue << "\n"; ++Failed; }