test: more robust test<->deployment binding

The anonymous function is bound to the loop variables which change
their content. This works with the current Ginkgo v1.12.1
where Describe calls the function immediately, but in Ginkgo v1.14.1
that changes and the function is stored and called much later.

To prepare for that, each function instance must be bound to copies of
the loop variables. Otherwise for example a test for
"operator" runs with the deployment for "direct-testing".

Author: pohly

test/e2e/deploy/deploy.go

@@ -1050,7 +1050,9 @@ func Describe(deployment, describe, what string, f func(d *Deployment)) bool {
 // DefineTests must be called to register all tests defined so far via Describe.
 func DefineTests() {
 	for deploymentName, group := range tests {
+		deploymentName := deploymentName
 		for describe, funcs := range group {
+			funcs := funcs
 			ginkgo.Describe(describe, func() {
 				deployment := EnsureDeployment(deploymentName)
 				for _, f := range funcs {