RDMA/qedr: Use true and false for bool variable

Jiapeng Chong · jgunthorpe · commit 1a93e848b730 · 2021-02-16T14:42:58.000-04:00
Fix the following coccicheck warning: ./drivers/infiniband/hw/qedr/qedr.h:629:9-10: WARNING: return of 0/1 in function 'qedr_qp_has_rq' with return type bool. ./drivers/infiniband/hw/qedr/qedr.h:620:9-10: WARNING: return of 0/1 in function 'qedr_qp_has_sq' with return type bool. Link: https://lore.kernel.org/r/1612949901-109873-1-git-send-email-jiapeng.chong@linux.alibaba.com Reported-by: Abaci Robot<abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Acked-by: Michal Kalderon <michal.kalderon@marvell.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
diff --git a/drivers/infiniband/hw/qedr/qedr.h b/drivers/infiniband/hw/qedr/qedr.h
@@ -617,18 +617,18 @@ static inline bool qedr_qp_has_srq(struct qedr_qp *qp)
 static inline bool qedr_qp_has_sq(struct qedr_qp *qp)
 {
 	if (qp->qp_type == IB_QPT_GSI || qp->qp_type == IB_QPT_XRC_TGT)
-		return 0;
+		return false;
 
-	return 1;
+	return true;
 }
 
 static inline bool qedr_qp_has_rq(struct qedr_qp *qp)
 {
 	if (qp->qp_type == IB_QPT_GSI || qp->qp_type == IB_QPT_XRC_INI ||
 	    qp->qp_type == IB_QPT_XRC_TGT || qedr_qp_has_srq(qp))
-		return 0;
+		return false;
 
-	return 1;
+	return true;
 }
 
 static inline struct qedr_user_mmap_entry *

Original file line number	Diff line number	Diff line change
`@@ -617,18 +617,18 @@ static inline bool qedr_qp_has_srq(struct qedr_qp *qp)`
`617`	`617`	`static inline bool qedr_qp_has_sq(struct qedr_qp *qp)`
`618`	`618`	`{`
`619`	`619`	`if (qp->qp_type == IB_QPT_GSI \|\| qp->qp_type == IB_QPT_XRC_TGT)`
`620`		`- return 0;`
	`620`	`+ return false;`
`621`	`621`
`622`		`- return 1;`
	`622`	`+ return true;`
`623`	`623`	`}`
`624`	`624`
`625`	`625`	`static inline bool qedr_qp_has_rq(struct qedr_qp *qp)`
`626`	`626`	`{`
`627`	`627`	`if (qp->qp_type == IB_QPT_GSI \|\| qp->qp_type == IB_QPT_XRC_INI \|\|`
`628`	`628`	`qp->qp_type == IB_QPT_XRC_TGT \|\| qedr_qp_has_srq(qp))`
`629`		`- return 0;`
	`629`	`+ return false;`
`630`	`630`
`631`		`- return 1;`
	`631`	`+ return true;`
`632`	`632`	`}`
`633`	`633`
`634`	`634`	`static inline struct qedr_user_mmap_entry *`