Skip to content

Commit b4d5284

Browse files
liubinBin Liu
authored andcommitted
fix(session): fix invalid data type in SessionRegenerate (goharbor#22726)
Signed-off-by: Bin Liu <lb203159@antfin.com> Co-authored-by: Bin Liu <lb203159@antfin.com>
1 parent b11c77e commit b4d5284

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

src/core/session/session.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ func (rp *Provider) SessionRegenerate(ctx context.Context, oldsid, sid string) (
172172
}
173173
maxlifetime := time.Duration(systemSessionTimeout(ctx, rp.maxlifetime))
174174
if isExist, _ := rp.SessionExist(ctx, oldsid); !isExist {
175-
err := rp.c.Save(ctx, sid, "", time.Duration(rp.maxlifetime))
175+
err := rp.c.Save(ctx, sid, map[any]any{}, time.Duration(rp.maxlifetime))
176176
if err != nil {
177177
log.Debugf("failed to save sid=%s, where oldsid=%s, error: %s", sid, oldsid, err)
178178
}

src/core/session/session_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,20 @@ func (s *sessionTestSuite) TestSessionRegenerate() {
8686

8787
err = s.provider.SessionDestroy(ctx, "session-003")
8888
s.NoError(err)
89+
90+
err = s.provider.SessionDestroy(ctx, "session-004")
91+
s.NoError(err)
8992
}()
9093

9194
_, err = s.provider.SessionRegenerate(ctx, "session-001", "session-003")
9295
s.NoError(err, "session regenerate should not error")
9396

9497
s.True(s.provider.SessionExist(ctx, "session-003"))
9598
s.False(s.provider.SessionExist(ctx, "session-001"))
99+
100+
_, err = s.provider.SessionRegenerate(ctx, "session-001", "session-004")
101+
s.NoError(err, "session regenerate should not error")
102+
s.True(s.provider.SessionExist(ctx, "session-004"))
96103
}
97104

98105
func (s *sessionTestSuite) TestSessionDestroy() {

0 commit comments

Comments
 (0)