Allow options on Mash#load#474
Merged
michaelherold merged 8 commits intohashie:masterfrom Mar 22, 2019
Merged
Conversation
Member
Author
|
@michaelherold Care to CR/squash/merge? Thanks. |
dblock
force-pushed
the
blabo-feature/enable_load_symbol
branch
2 times, most recently
from
9d7fbc1 to
83cc64c
Compare
dblock
force-pushed
the
blabo-feature/enable_load_symbol
branch
from
83cc64c to
01b511b
Compare
dblock
force-pushed
the
blabo-feature/enable_load_symbol
branch
from
74a1621 to
6b90f31
Compare
michaelherold
approved these changes
Mar 22, 2019
Member
michaelherold
left a comment
michaelherold
left a comment
There was a problem hiding this comment.
I'm good with this. The tests for the Psych::DisallowedClass were a little unclear but that's due to the nature of the stdlib implementation. I can't fault you for that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A replacement for #473. The only users affected by this change would be those that have rolled a custom parser, vs. #473 that affects everyone who calls
Mash#load.Mash#load.Mash.load(file, whitelist_classes: [Symbol])which was the desired effect of Enable load symbol class #473, and can specify other options such asaliases.