Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Security issue in dependencies #1425

Open
Adrion opened this issue Apr 30, 2018 · 5 comments
Open

Security issue in dependencies #1425

Adrion opened this issue Apr 30, 2018 · 5 comments

Comments

@Adrion
Copy link

Adrion commented Apr 30, 2018

Security issue in dependencies

ionic-app-scripts requires node-sass 4.7.2
sass/node-sass#2355

ionic-app-scripts
|-node-sass
 |-request
  |-hawk
   |-hoek

Still no upgrades for node-sass, but we have to register the issue here for dependency upgrade.

@peterennis
Copy link

@adamdbradley

I see that also, and GitHub is sending out notices.

2018-04-30 20_16_58- 184 unread - peterennis yahoo com - yahoo mail

C:\ae\adaept.com\aeicons>npm ls hoek
[email protected] C:\ae\adaept.com\aeicons
`-- @ionic/[email protected]
  `-- [email protected]
    `-- [email protected]
      `-- [email protected]
        +-- [email protected]
        | `-- [email protected]  deduped
        +-- [email protected]
        `-- [email protected]
          `-- [email protected]  deduped


C:\ae\adaept.com\aeicons>

@peterennis
Copy link

This is being addressed at the top level by npm here: https://github.com/npm/npm/releases
Testing the issue here: ionic-team/ionic-framework#14497

@shlomiLan
Copy link

What should be the fix for this issue? I have tried running npm audit fix and that found and fixed lots of problem but not this one. When I run npm ls hoek I get:

├─┬ @ionic/[email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       ├─┬ [email protected]
│       │ └── [email protected] 
│       ├── [email protected] 
│       └─┬ [email protected]
│         └── [email protected] 

I'm using Ionic 3

@peterennis
Copy link

The following ionic-team/ionic-framework#14920 is a duplicate of this.

@byzg
Copy link

byzg commented Sep 26, 2018

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants