Skip to content

Commit 474788b

Browse files
Gleb Mikheevimhoffd
authored andcommitted
fix(serve): pass through proxyConfig to dev-server (#3457)
1 parent bf10674 commit 474788b

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

packages/@ionic/ng-toolkit/src/cordova-serve/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ export class CordovaServeBuilder implements Builder<CordovaServeBuilderSchema> {
1515

1616
run(builderConfig: BuilderConfiguration<CordovaServeBuilderSchema>): Observable<BuildEvent> {
1717
const [ project, target, configuration ] = builderConfig.options.devServerTarget.split(':');
18-
const { port, host } = builderConfig.options;
19-
const devServerTargetSpec = { project, target, configuration, overrides: { port, host } };
18+
const { port, host, proxyConfig } = builderConfig.options;
19+
const devServerTargetSpec = { project, target, configuration, overrides: { port, host, proxyConfig } };
2020
const devServerBuilderConfig = this.context.architect.getBuilderConfiguration</* DevServerBuilderSchema */any>(devServerTargetSpec);
2121

2222
// TODO: architect doesn't use the defaults from schema

packages/@ionic/ng-toolkit/src/cordova-serve/schema.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@ export interface CordovaServeBuilderSchema {
44
platform: string;
55
port?: number;
66
host?: string;
7+
proxyConfig?: string;
78
cordovaBasePath?: string;
89
}

packages/@ionic/ng-toolkit/src/cordova-serve/schema.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@
1515
"type": "string",
1616
"description": "Cordova platform to use during serve."
1717
},
18+
"proxyConfig": {
19+
"type": "string",
20+
"description": "Proxy configuration file."
21+
},
1822
"port": {
1923
"type": "number",
2024
"description": "Port to listen on.",

0 commit comments

Comments
 (0)