fix(cordova): recognize more browsers

fixes #2826

Author: imhoffd

packages/@ionic/cli-utils/src/definitions.ts

@@ -686,7 +686,7 @@ export interface ResourcesConfig {
   [propName: string]: ResourcesPlatform;
 }
 
-export type KnownPlatform = 'ios' | 'android' | 'wp8';
+export type KnownPlatform = 'ios' | 'android' | 'wp8' | 'windows' | 'browser';
 export type KnownResourceType = 'icon' | 'splash';
 
 export interface StarterTemplate {

packages/@ionic/cli-utils/src/lib/cordova/__tests__/project.ts

@@ -8,7 +8,7 @@ describe('@ionic/cli-utils', () => {
     describe('getPlatforms', () => {
 
       it('should filter out platforms.json and empty string', async () => {
-        spyOn(fsSpy, 'readDir').and.callFake(async () => ['android', 'ios', 'platforms.json', '']);
+        spyOn(fsSpy, 'readDir').and.callFake(async () => ['.DS_Store', 'android', 'ios', 'platforms.json', '']);
         const platforms = await project.getPlatforms('/path/to/proj');
         expect(platforms).toEqual(['android', 'ios']);
       });

packages/@ionic/cli-utils/src/lib/cordova/project.ts

@@ -2,19 +2,15 @@ import * as path from 'path';
 
 import chalk from 'chalk';
 
-import { IonicEnvironment, KnownPlatform } from '../../definitions';
+import { IonicEnvironment } from '../../definitions';
 
 import { FatalException } from '../errors';
 import { readDir } from '@ionic/cli-framework/utils/fs';
 
-function isKnownPlatform(platform: string): platform is KnownPlatform {
-  return ['android', 'ios'].includes(platform);
-}
-
 export async function getPlatforms(projectDir: string): Promise<string[]> {
   const platformsDir = path.resolve(projectDir, 'platforms');
   const dirContents = await readDir(platformsDir);
-  return dirContents.filter(f => f && isKnownPlatform(f));
+  return dirContents.filter(f => f && f !== 'platforms.json' && !f.startsWith('.'));
 }
 
 export async function installPlatform(env: IonicEnvironment, platform: string): Promise<void> {