Skip to content

[Bug][Crit] Remove '.bold' or '.bold()' method from cli utils #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luchillo17 opened this issue Sep 6, 2016 · 2 comments
Closed

[Bug][Crit] Remove '.bold' or '.bold()' method from cli utils #1344

luchillo17 opened this issue Sep 6, 2016 · 2 comments

Comments

@luchillo17
Copy link

luchillo17 commented Sep 6, 2016

Related to this post comment #1038 (comment) the .bold() method doesn't work in terminals as the cli expects, this generates an error of type TypeError: Can't call method on undefined, that itself blocks the user to see the original error, many of us have had to get into the lib itself and remove that part of the code just to see the original error, and that repeats each time we update the ionic-cli.

The line in question is in /lib/node_modules/ionic/lib/utils/cordova.js:83 in other peoples pc, in my case is in /usr/local/lib/node_modules/ionic/lib/utils/cordova.js:83 which means is in the ionic-cli cordova utils, line 83.

This should be fixed now, for starters not all ionic devs are good enough to go edit this file in node_modules, most of them will never know or care about that particular problem, and as such will never know what's their real bug, and the ones like me that do know this issue exists is a nuisance to do this deletion each time we update the ionic-cli library.

@ahmed-abdulmoniem
Copy link

Any permanent fix to this?

@imhoffd
Copy link
Contributor

imhoffd commented Feb 7, 2018

Should be resolved in the latest version of the CLI, which now uses chalk.

@imhoffd imhoffd closed this as completed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants