-
Notifications
You must be signed in to change notification settings - Fork 670
Make Cordova entirely opt-in (--cordova) #2595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What will the question be here? Please include something like "Do you want to build for native mobile platforms?" so it is really clear what htis is, otherwise this will lead to so many posts and issues with newbies accidentally missing stuff.
Cordova files are identical for all starters (minus the changes made by CLI for name and package ID) afaik. Wouldn't it make sense to move these files out of the starters (into its own repo that is applied on top of base and starter)? A bigger thought: |
The question is currently:
That's precisely what I thought of doing, but I may also put them in the Ionic CLI repo as templates. As for your last question, Cordova has a very strict app structure. I'm not sure it's a huge deal that those are in the base level, either. |
Sounds good.
Better, less to download. And Cordova moves much slower than the starter templates anyway.
Imagine |
📝 Also have an |
This is pretty much done with 3.17.0 and 3.18.0.
|
As of CLI 3.7,
ionic start
asks the dev if they'd like to integrate Cordova with their app. If they respond no, Cordova files from the starters still get included, such asconfig.xml
and all the default resources. This shouldn't happen.ionic start
.The text was updated successfully, but these errors were encountered: