Skip to content

ng-toolkit #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imhoffd opened this issue Apr 24, 2018 · 4 comments
Closed

ng-toolkit #3103

imhoffd opened this issue Apr 24, 2018 · 4 comments
Labels
project type: angular Ionic Angular 4+ projects

Comments

@imhoffd
Copy link
Contributor

imhoffd commented Apr 24, 2018

We should add @ionic/ng-toolkit as a separation layer between the third-party Angular CLI so that it can be versioned independently of the Ionic CLI.

This would let people keep the Ionic CLI up-to-date even if they needed an older version of the Angular CLI.

Tying the Angular CLI API to the Ionic CLI has already resulted in these issues:

@imhoffd imhoffd added this to the Ionic Angular 4 milestone Apr 24, 2018
@ionitron-bot ionitron-bot bot added the triage label Apr 24, 2018
@imhoffd imhoffd removed the triage label Apr 24, 2018
@imhoffd
Copy link
Contributor Author

imhoffd commented Apr 24, 2018

@imhoffd
Copy link
Contributor Author

imhoffd commented May 30, 2018

The plan is to use ng-toolkit as a library much like @angular-devkit/build-angular: https://github.com/angular/devkit/tree/master/packages/angular_devkit/build_angular

We can pass in configuration unrelated to Angular build/serve logic via environment variables by using builder options passed in via command line.

cc @stupidawesome

@imhoffd
Copy link
Contributor Author

imhoffd commented Jun 2, 2018

📝 RC.7 will need updated starters to include the ng-toolkit

@imhoffd
Copy link
Contributor Author

imhoffd commented Jun 14, 2018

In RC.8

@imhoffd imhoffd closed this as completed Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project type: angular Ionic Angular 4+ projects
Projects
None yet
Development

No branches or pull requests

1 participant