Skip to content

Commit 71cb202

Browse files
committed
fix(popover): extend options to modal service
Closes #2724
1 parent 69c733a commit 71cb202

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

js/angular/service/popover.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,8 @@ function($ionicModal, $ionicPosition, $document, $window) {
212212
* @returns {promise} A promise that will be resolved with an instance of
213213
* an {@link ionic.controller:ionicPopover} controller (ionicPopover is built on top of $ionicPopover).
214214
*/
215-
fromTemplateUrl: function(url, options, _) {
216-
return $ionicModal.fromTemplateUrl(url, options, ionic.Utils.extend(POPOVER_OPTIONS, options || {}));
215+
fromTemplateUrl: function(url, options) {
216+
return $ionicModal.fromTemplateUrl(url, ionic.Utils.extend(POPOVER_OPTIONS, options || {}));
217217
}
218218
};
219219

test/unit/angular/service/popover.unit.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe('Ionic Popover', function() {
3636

3737
var done = false;
3838

39-
var instance = popover.fromTemplateUrl('popover.html', function(instance) {
39+
popover.fromTemplateUrl('popover.html').then(function(instance) {
4040
done = true;
4141
instance.show();
4242
expect(instance.el.classList.contains('popover-backdrop')).toBe(true);

0 commit comments

Comments
 (0)