-
Notifications
You must be signed in to change notification settings - Fork 13.5k
bug: no level one heading in apps #23746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the issue. Is there a particular issue you are running into with the way |
I did state that it should be "when used in a page header", but maybe I didn't make my request clear enough. I understand if this would be too complex. If that is the case, please say so, and I will (try to) forget about it. Alternative, rather hacky solution I think should work for most cases: just put an |
Thanks for the clarification. I worry that adding this logic into Are you running into a particular accessibility issue/warning? |
Currently, axe DevTools gives a warning that the page has no level-one heading, and Windows Narrator (I have not tried other screen readers yet) does not read the title out. It reads the back button I have in the toolbar, and then reads the content of the page. |
ion-title
use an h1
Thanks. I think this is something Ionic should handle/make easier. One idea is to keep the scope extremely limited and just have it render an |
Thanks for the issue. After making a proof of concept and discussing this with the team we have decided to add documentation to inform devs on how to add proper headings in their applications. We found that trying to automatically account for this in Ionic resulted in very brittle code because The docs are live, so I am going to close this. Let me know if you have any questions. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prequisites
Describe the Feature Request
Make the internal element used by
ion-title
anh1
when used in a page header.This improves accessibility.
Describe the Use Case
This greatly improves accessibility.
There are many more small changes like this that could be made throughout the framework...
Describe Preferred Solution
ion-title
currently always uses adiv
. An actual header element could be used instead.Describe Alternatives
No response
Related Code
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: