From 3cc6cc63cfa0eb63eef45f3799964afe1d154231 Mon Sep 17 00:00:00 2001 From: Alan Shaw Date: Tue, 27 Nov 2018 12:47:32 +0000 Subject: [PATCH 1/2] chore: increase ping timeouts This takes around 15s locally and can take significantly longer in CI. License: MIT Signed-off-by: Alan Shaw --- js/src/ping/ping-pull-stream.js | 2 +- js/src/ping/ping-readable-stream.js | 2 +- js/src/ping/ping.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/src/ping/ping-pull-stream.js b/js/src/ping/ping-pull-stream.js index 3048c732a..1e98f2d47 100644 --- a/js/src/ping/ping-pull-stream.js +++ b/js/src/ping/ping-pull-stream.js @@ -14,7 +14,7 @@ module.exports = (createCommon, options) => { const common = createCommon() describe('.pingPullStream', function () { - this.timeout(60 * 1000) + this.timeout(2 * 60 * 1000) let ipfsA let ipfsB diff --git a/js/src/ping/ping-readable-stream.js b/js/src/ping/ping-readable-stream.js index 8f9da6e21..662155b43 100644 --- a/js/src/ping/ping-readable-stream.js +++ b/js/src/ping/ping-readable-stream.js @@ -15,7 +15,7 @@ module.exports = (createCommon, options) => { const common = createCommon() describe('.pingReadableStream', function () { - this.timeout(60 * 1000) + this.timeout(2 * 60 * 1000) let ipfsA let ipfsB diff --git a/js/src/ping/ping.js b/js/src/ping/ping.js index a485c982c..24b7e5e08 100644 --- a/js/src/ping/ping.js +++ b/js/src/ping/ping.js @@ -13,7 +13,7 @@ module.exports = (createCommon, options) => { const common = createCommon() describe('.ping', function () { - this.timeout(60 * 1000) + this.timeout(2 * 60 * 1000) let ipfsA let ipfsB From 7e7457e0da339195470b44648358296e54af94cf Mon Sep 17 00:00:00 2001 From: Alan Shaw Date: Thu, 29 Nov 2018 09:10:37 +0000 Subject: [PATCH 2/2] chore: add comments to give context to large timeouts License: MIT Signed-off-by: Alan Shaw --- js/src/ping/ping-pull-stream.js | 1 + js/src/ping/ping-readable-stream.js | 1 + js/src/ping/ping.js | 1 + 3 files changed, 3 insertions(+) diff --git a/js/src/ping/ping-pull-stream.js b/js/src/ping/ping-pull-stream.js index 1e98f2d47..28b8d056f 100644 --- a/js/src/ping/ping-pull-stream.js +++ b/js/src/ping/ping-pull-stream.js @@ -14,6 +14,7 @@ module.exports = (createCommon, options) => { const common = createCommon() describe('.pingPullStream', function () { + // TODO revisit when https://github.com/ipfs/go-ipfs/issues/5799 is resolved this.timeout(2 * 60 * 1000) let ipfsA diff --git a/js/src/ping/ping-readable-stream.js b/js/src/ping/ping-readable-stream.js index 662155b43..4d057fb61 100644 --- a/js/src/ping/ping-readable-stream.js +++ b/js/src/ping/ping-readable-stream.js @@ -15,6 +15,7 @@ module.exports = (createCommon, options) => { const common = createCommon() describe('.pingReadableStream', function () { + // TODO revisit when https://github.com/ipfs/go-ipfs/issues/5799 is resolved this.timeout(2 * 60 * 1000) let ipfsA diff --git a/js/src/ping/ping.js b/js/src/ping/ping.js index 24b7e5e08..2a4f1b913 100644 --- a/js/src/ping/ping.js +++ b/js/src/ping/ping.js @@ -13,6 +13,7 @@ module.exports = (createCommon, options) => { const common = createCommon() describe('.ping', function () { + // TODO revisit when https://github.com/ipfs/go-ipfs/issues/5799 is resolved this.timeout(2 * 60 * 1000) let ipfsA