Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit 351dea5

Browse files
alanshawalanshaw
committed
chore: add skip reasons
License: MIT Signed-off-by: Alan Shaw <[email protected]>
1 parent a7b722a commit 351dea5

File tree

1 file changed

+106
-60
lines changed

1 file changed

+106
-60
lines changed

‎test/interface.spec.js

+106-60
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ describe('interface-ipfs-core tests', () => {
1313
tests.bitswap(defaultCommonFactory, {
1414
skip: [
1515
// bitswap.unwant
16-
// FIXME why is this skipped?
17-
'should remove a key from the wantlist'
16+
{
17+
name: 'should remove a key from the wantlist',
18+
reason: 'FIXME why is this skipped?'
19+
}
1820
]
1921
})
2022

@@ -25,103 +27,145 @@ describe('interface-ipfs-core tests', () => {
2527
tests.config(defaultCommonFactory, {
2628
skip: [
2729
// config.replace
28-
// FIXME Waiting for fix on go-ipfs
29-
// - https://github.com/ipfs/js-ipfs-api/pull/307#discussion_r69281789
30-
// - https://github.com/ipfs/go-ipfs/issues/2927
31-
'replace'
30+
{
31+
name: 'replace',
32+
reason: 'FIXME Waiting for fix on go-ipfs https://github.com/ipfs/js-ipfs-api/pull/307#discussion_r69281789 and https://github.com/ipfs/go-ipfs/issues/2927'
33+
}
3234
]
3335
})
3436

3537
tests.dag(defaultCommonFactory, {
3638
skip: [
3739
// dag.tree
38-
// TODO vmx 2018-02-22: Currently the tree API is not exposed in go-ipfs
39-
'tree',
40+
{
41+
name: 'tree',
42+
reason: 'TODO vmx 2018-02-22: Currently the tree API is not exposed in go-ipfs'
43+
},
4044
// dag.get:
41-
// FIXME vmx 2018-02-22: Currently not supported in go-ipfs, it might
42-
// be possible once https://github.com/ipfs/go-ipfs/issues/4728 is
43-
// done
44-
'should get a dag-pb node local value',
45-
'should get dag-pb value via dag-cbor node',
46-
'should get by CID string + path',
45+
{
46+
name: 'should get a dag-pb node local value',
47+
reason: 'FIXME vmx 2018-02-22: Currently not supported in go-ipfs, it might be possible once https://github.com/ipfs/go-ipfs/issues/4728 is done'
48+
},
49+
{
50+
name: 'should get dag-pb value via dag-cbor node',
51+
reason: 'FIXME vmx 2018-02-22: Currently not supported in go-ipfs, it might be possible once https://github.com/ipfs/go-ipfs/issues/4728 is done'
52+
},
53+
{
54+
name: 'should get by CID string + path',
55+
reason: 'FIXME vmx 2018-02-22: Currently not supported in go-ipfs, it might be possible once https://github.com/ipfs/go-ipfs/issues/4728 is done'
56+
},
4757
// dag.put
48-
// FIXME This works in go-ipfs because dag-pb will serialize any object. If
49-
// the object has neither a `data` nor `links` field it's serialized
50-
// as an empty object
51-
'should not put dag-cbor node with wrong multicodec'
58+
{
59+
name: 'should not put dag-cbor node with wrong multicodec',
60+
reason: 'FIXME This works in go-ipfs because dag-pb will serialize any object. If the object has neither a `data` nor `links` field it\'s serialized as an empty object'
61+
}
5262
]
5363
})
5464

5565
tests.dht(defaultCommonFactory, {
5666
skip: [
5767
// dht.findpeer
58-
// FIXME checking what is exactly go-ipfs returning
59-
// https://github.com/ipfs/go-ipfs/issues/3862#issuecomment-294168090
60-
'should fail to find other peer if peer does not exist',
68+
{
69+
name: 'should fail to find other peer if peer does not exist',
70+
reason: 'FIXME checking what is exactly go-ipfs returning https://github.com/ipfs/go-ipfs/issues/3862#issuecomment-294168090'
71+
},
6172
// dht.findprovs
62-
// FIXME go-ipfs endpoint doesn't conform with the others
63-
// https://github.com/ipfs/go-ipfs/issues/5047
64-
'should provide from one node and find it through another node',
73+
{
74+
name: 'should provide from one node and find it through another node',
75+
reason: 'FIXME go-ipfs endpoint doesn\'t conform with the others https://github.com/ipfs/go-ipfs/issues/5047'
76+
},
6577
// dht.get
66-
// FIXME go-ipfs errors with Error: key was not found (type 6)
67-
// https://github.com/ipfs/go-ipfs/issues/3862
68-
'should get a value after it was put on another node'
78+
{
79+
name: 'should get a value after it was put on another node',
80+
reason: 'FIXME go-ipfs errors with Error: key was not found (type 6) https://github.com/ipfs/go-ipfs/issues/3862'
81+
}
6982
]
7083
})
7184

7285
tests.files(defaultCommonFactory, {
7386
skip: [
7487
// files.add
75-
// FIXME https://github.com/ipfs/js-ipfs-api/issues/339
76-
isNode ? null : 'should add a nested directory as array of tupples',
77-
isNode ? null : 'should add a nested directory as array of tupples with progress',
88+
isNode ? null : {
89+
name: 'should add a nested directory as array of tupples',
90+
reason: 'FIXME https://github.com/ipfs/js-ipfs-api/issues/339'
91+
},
92+
isNode ? null : {
93+
name: 'should add a nested directory as array of tupples with progress',
94+
reason: 'FIXME https://github.com/ipfs/js-ipfs-api/issues/339'
95+
},
7896
// files.addPullStream
79-
// FIXME https://github.com/ipfs/js-ipfs-api/issues/339
80-
isNode ? null : 'should add pull stream of valid files and dirs',
97+
isNode ? null : {
98+
name: 'should add pull stream of valid files and dirs',
99+
reason: 'FIXME https://github.com/ipfs/js-ipfs-api/issues/339'
100+
},
81101
// files.addReadableStream
82-
// FIXME https://github.com/ipfs/js-ipfs-api/issues/339
83-
isNode ? null : 'should add readable stream of valid files and dirs',
102+
isNode ? null : {
103+
name: 'should add readable stream of valid files and dirs',
104+
reason: 'FIXME https://github.com/ipfs/js-ipfs-api/issues/339'
105+
},
84106
// files.catPullStream
85-
// TODO not implemented in go-ipfs yet
86-
'should export a chunk of a file',
87-
'should export a chunk of a file in a Pull Stream',
88-
'should export a chunk of a file in a Readable Stream',
107+
{
108+
name: 'should export a chunk of a file',
109+
reason: 'TODO not implemented in go-ipfs yet'
110+
},
111+
{
112+
name: 'should export a chunk of a file in a Pull Stream',
113+
reason: 'TODO not implemented in go-ipfs yet'
114+
},
115+
{
116+
name: 'should export a chunk of a file in a Readable Stream',
117+
reason: 'TODO not implemented in go-ipfs yet'
118+
},
89119
// files.get
90-
// FIXME https://github.com/ipfs/js-ipfs-api/issues/339
91-
isNode ? null : 'should get a directory'
120+
isNode ? null : {
121+
name: 'should get a directory',
122+
reason: 'FIXME https://github.com/ipfs/js-ipfs-api/issues/339'
123+
}
92124
]
93125
})
94126

95127
tests.key(defaultCommonFactory, {
96128
skip: [
97129
// key.export
98-
// TODO not implemented in go-ipfs yet
99-
'export',
130+
{
131+
name: 'export',
132+
reason: 'TODO not implemented in go-ipfs yet'
133+
},
100134
// key.import
101-
// TODO not implemented in go-ipfs yet
102-
'import'
135+
{
136+
name: 'import',
137+
reason: 'TODO not implemented in go-ipfs yet'
138+
}
103139
]
104140
})
105141

106142
tests.ls(defaultCommonFactory, {
107143
skip: [
108144
// lsPullStream
109-
// FIXME https://github.com/ipfs/js-ipfs-api/issues/339
110-
isNode ? null : 'should pull stream ls with a base58 encoded CID',
145+
isNode ? null : {
146+
name: 'should pull stream ls with a base58 encoded CID',
147+
reason: 'FIXME https://github.com/ipfs/js-ipfs-api/issues/339'
148+
},
111149
// lsReadableStream
112-
// FIXME https://github.com/ipfs/js-ipfs-api/issues/339
113-
isNode ? null : 'should readable stream ls with a base58 encoded CID',
150+
isNode ? null : {
151+
name: 'should readable stream ls with a base58 encoded CID',
152+
reason: 'FIXME https://github.com/ipfs/js-ipfs-api/issues/339'
153+
},
114154
// ls
115-
// FIXME https://github.com/ipfs/js-ipfs-api/issues/339
116-
isNode ? null : 'should ls with a base58 encoded CID'
155+
isNode ? null : {
156+
name: 'should ls with a base58 encoded CID',
157+
reason: 'FIXME https://github.com/ipfs/js-ipfs-api/issues/339'
158+
}
117159
]
118160
})
119161

120162
tests.miscellaneous(defaultCommonFactory, {
121163
skip: [
122164
// stop
123-
// FIXME go-ipfs returns an error https://github.com/ipfs/go-ipfs/issues/4078
124-
'should stop the node'
165+
{
166+
name: 'should stop the node',
167+
reason: 'FIXME go-ipfs returns an error https://github.com/ipfs/go-ipfs/issues/4078'
168+
}
125169
]
126170
})
127171

@@ -139,10 +183,14 @@ describe('interface-ipfs-core tests', () => {
139183
}), {
140184
skip: isNode ? [
141185
// pubsub.subscribe
142-
// FIXME https://github.com/ipfs/interface-ipfs-core/pull/188#issuecomment-354673246
143-
// and https://github.com/ipfs/go-ipfs/issues/4778
144-
isWindows ? 'should send/receive 100 messages' : null,
145-
isWindows ? 'should receive multiple messages' : null
186+
isWindows ? {
187+
name: 'should send/receive 100 messages',
188+
reason: 'FIXME https://github.com/ipfs/interface-ipfs-core/pull/188#issuecomment-354673246 and https://github.com/ipfs/go-ipfs/issues/4778'
189+
} : null,
190+
isWindows ? {
191+
name: 'should receive multiple messages',
192+
reason: 'FIXME https://github.com/ipfs/interface-ipfs-core/pull/188#issuecomment-354673246 and https://github.com/ipfs/go-ipfs/issues/4778'
193+
} : null
146194
] : true
147195
})
148196

@@ -181,9 +229,7 @@ describe('interface-ipfs-core tests', () => {
181229
}
182230
}))
183231

184-
// FIXME currently failing
185-
tests.types(defaultCommonFactory, { skip: true })
232+
tests.types(defaultCommonFactory, { skip: { reason: 'FIXME currently failing' } })
186233

187-
// FIXME currently failing
188-
tests.util(defaultCommonFactory, { skip: true })
234+
tests.util(defaultCommonFactory, { skip: { reason: 'FIXME currently failing' } })
189235
})

0 commit comments

Comments
 (0)