Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

.refs test on Windows #645

Closed
richardschneider opened this issue Dec 15, 2017 · 2 comments · Fixed by #647
Closed

.refs test on Windows #645

richardschneider opened this issue Dec 15, 2017 · 2 comments · Fixed by #647
Assignees
@richardschneider

Comments

@richardschneider
Copy link
Contributor

richardschneider commented Dec 15, 2017 •
edited
Loading

The .refs test uses a symlink file that is in the git repository. On *nix ipfs add will use the contents of the target file. On Windows, the file is not a symlink, so ipfs add uses the contents of the file not the target.

This breaks the tests, because the hash of the top level directory is now different on Windows. See #644
@richardschneider
Copy link
Contributor Author

It looks like #637 was closed prematurely.

@richardschneider
Copy link
Contributor Author

From https://www.quora.com/How-does-git-handle-symbolic-links-on-Windows

In short: symlinks are not supported by git on Windows.
As a matter of fact, anyway, storing symlinks in git repositories is considered a bad practice.

@richardschneider richardschneider mentioned this issue Dec 16, 2017
Merged
@ghost ghost added the in progress label Dec 16, 2017
@ghost ghost removed the in progress label Dec 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardschneider richardschneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(refs): fix symlinks from git ipfs-inactive/js-ipfs-http-client
1 participant
@richardschneider