chore: replace dirty-chai with chai-parentheses (#788)

dirty-chai has issues with modern bundlers due to how it tries to support amd, cjs and script tags from one file.

Replace dirty-chai with chai-parentheses as we only care about running cjs or esm with bundlers.

Author: achingbrain

.github/workflows/main.yml

@@ -24,20 +24,20 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node }}
-      - run: yarn
+      - run: npm install
       - run: npm run test:node -- --bail --cov
       - uses: codecov/codecov-action@v1
   test-chrome:
     needs: check
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - run: yarn
+      - run: npm install
       - run: npm run test:browser
   test-firefox:
     needs: check
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - run: yarn
+      - run: npm install
       - run: npm run test:browser -- -- --browser firefox

package.json

@@ -62,7 +62,6 @@
     "@types/chai": "^4.2.16",
     "@types/chai-as-promised": "^7.1.3",
     "@types/chai-subset": "^1.3.3",
-    "@types/dirty-chai": "^2.0.2",
     "@types/mocha": "^8.2.2",
     "@types/node": "^14.14.37",
     "@types/sinon": "^9.0.11",
@@ -73,13 +72,13 @@
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "chai-bytes": "^0.1.2",
+    "chai-parentheses": "^0.0.2",
     "chai-string": "^1.5.0",
     "chai-subset": "^1.6.0",
     "conventional-changelog": "^3.1.24",
     "conventional-github-releaser": "^3.1.5",
     "copyfiles": "^2.4.1",
     "cors": "^2.8.5",
-    "dirty-chai": "^2.0.1",
     "electron-mocha": "^10.0.0",
     "env-paths": "^2.2.1",
     "esbuild": "0.11.5",

utils/chai.js

@@ -4,7 +4,7 @@ const chai = require('chai')
 
 // Do not reorder these statements - https://github.com/chaijs/chai/issues/1298
 chai.use(require('chai-as-promised'))
-chai.use(require('dirty-chai'))
+chai.use(require('chai-parentheses'))
 chai.use(require('chai-subset'))
 chai.use(require('chai-bytes'))
 chai.use(require('chai-string'))