This repository was archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
DAG API example is wrong #307
Labels
Comments
This is related to ipld/js-ipld#82 |
@PascalPrecht any chance you can send a PR to fix this up? 😉 🙏 |
On my way! |
Well actually, the algorithm is right, but the hash should be different. I guess the example should demonstrate how to override the default hash algorithm (which is already sha-256). I'll send a PR to update the hash |
0x-r4bbit
added a commit
to 0x-r4bbit/interface-ipfs-core
that referenced
this issue
Aug 7, 2018
Closes ipfs-inactive#307 License: MIT Signed-off-by: Pascal Precht <[email protected]>
alanshaw
pushed a commit
that referenced
this issue
Aug 7, 2018
…347) Closes #307 License: MIT Signed-off-by: Pascal Precht <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The
dag.put
example in https://github.com/ipfs/interface-ipfs-core/blob/master/SPEC/DAG.md is wrong.The expected cid of
zdpuAzE1oAAMpsfdoexcJv6PmL9UhE8nddUYGU32R98tzV5fv
decodes asbase58btc cidv1 dag-cbor sha2-256 Qmc9E2LoddF1MdSVzYaaFxr6iByWSa2Q7pSpiKHcV4drm6
.The hash algorithm should be
sha3-512
notsha2-256
.The text was updated successfully, but these errors were encountered: