fix: correctly differentiate pong responses

alanshaw · alanshaw · commit 4ad25a3e8bcb · 2018-05-24T21:03:37.000+01:00
Investigation discovered that pong responses CAN have `time: 0` (they can be very quick). Previously pong messages were differentiated by time greater than 0, but considering it can be 0 this was incorrect.

License: MIT
Signed-off-by: Alan Shaw &lt;alan@tableflip.io&gt;
diff --git a/test/ping.spec.js b/test/ping.spec.js
@@ -17,7 +17,7 @@ const f = require('./utils/factory')
 
 // Determine if a ping response object is a pong, or something else, like a status message
 function isPong (pingResponse) {
-  return Boolean(pingResponse && pingResponse.time)
+  return Boolean(pingResponse && pingResponse.success && !pingResponse.text)
 }
 
 describe('.ping', function () {

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ const f = require('./utils/factory')`
`17`	`17`
`18`	`18`	`// Determine if a ping response object is a pong, or something else, like a status message`
`19`	`19`	`function isPong (pingResponse) {`
`20`		`- return Boolean(pingResponse && pingResponse.time)`
	`20`	`+ return Boolean(pingResponse && pingResponse.success && !pingResponse.text)`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`describe('.ping', function () {`