chore: apply suggestions from code review

Co-Authored-By: dirkmc <[email protected]>

Author: vasco-santos

src/core/components/start.js

@@ -1,6 +1,7 @@
 'use strict'
 
 const get = require('dlv')
+const callbackify = require('callbackify')
 const series = require('async/series')
 const Bitswap = require('ipfs-bitswap')
 const setImmediate = require('async/setImmediate')
@@ -48,8 +49,18 @@ module.exports = (self) => {
             if (err) return cb(err)
             self.libp2p = libp2p
 
+            // create provider
             self._provider = new Provider(libp2p, self._repo.blocks, get(config, 'Reprovider'))
-            cb()
+
+            // start provider if libp2p routing enabled
+            if (!get(self._options, 'offline') &&
+              (get(self._options, 'libp2p.config.dht.enabled', false) || get(self._options, 'libp2p.modules.contentRouting', false))) {
+              const providerStart = callbackify(() => self._provider.start())
+
+              providerStart(cb)
+            } else {
+              cb()
+            }
           })
         })
       },
@@ -64,11 +75,6 @@ module.exports = (self) => {
           { statsEnabled: true }
         )
 
-        if (!get(self._options, 'offline') &&
-          (get(self._options, 'libp2p.config.dht.enabled', false) || get(self._options, 'libp2p.modules.contentRouting', false))) {
-          self._provider.start()
-        }
-
         self._bitswap.start()
         self._blockService.setExchange(self._bitswap)
 

src/core/provider/index.js

@@ -63,7 +63,7 @@ class Provider {
    * @returns {void}
    */
   stop () {
-    this._running = true
+    this._running = false
 
     // stop the reprovider
     this.reprovider.stop()

src/core/provider/reprovider.js

@@ -11,8 +11,8 @@ class Reprovider {
    * @param {object} contentRouting
    * @param {Blockstore} blockstore
    * @param {object} options
-   * @param {string} options.delay reprovider initial delay in human friendly time
-   * @param {string} options.interval reprovider interval in human friendly time
+   * @param {string} options.delay reprovider initial delay in milliseconds
+   * @param {string} options.interval reprovider interval in milliseconds
    * @param {string} options.strategy reprovider strategy
    */
   constructor (contentRouting, blockstore, options) {