fix: only accept cid for ipfs.dag.get

If you have a path within the DAG to resolve, pass it as `path` in
the options object as per the documentation.

Fixes #3637

Author: achingbrain

examples/traverse-ipld-graphs/get-path.js

@@ -15,13 +15,13 @@ async function main () {
   const cid = await ipfs.dag.put(myData, { format: 'dag-cbor', hashAlg: 'sha2-256' })
   let result
 
-  result = await ipfs.dag.get(cid, 'name')
+  result = await ipfs.dag.get(cid, { path: 'name' })
   console.log(result.value)
 
-  result = await ipfs.dag.get(cid, 'likes')
+  result = await ipfs.dag.get(cid, { path: 'likes' })
   console.log(result.value)
 
-  result = await ipfs.dag.get(cid + '/likes/0')
+  result = await ipfs.dag.get(cid, { path: '/likes/0' })
   console.log(result.value)
 }
 

examples/traverse-ipld-graphs/git.js

@@ -56,11 +56,11 @@ async function main () {
     console.log(result.value)
   }
 
-  await logResult(() => ipfs.dag.get(v1tag + '/'), 'Tag object:')
-  await logResult(() => ipfs.dag.get(v1tag + '/object/message'), 'Tagged commit message:')
-  await logResult(() => ipfs.dag.get(v1tag + '/object/parents/0/message'), 'Parent of tagged commit:')
-  await logResult(() => ipfs.dag.get(v1tag + '/object/tree/src/hash/hello/hash'), '/src/hello file:')
-  await logResult(() => ipfs.dag.get(v1tag + '/object/parents/0/tree/src/hash/hello/hash'), 'previous version of /src/hello file:')
+  await logResult(() => ipfs.dag.get(v1tag), 'Tag object:')
+  await logResult(() => ipfs.dag.get(v1tag, { path: '/object/message' }), 'Tagged commit message:')
+  await logResult(() => ipfs.dag.get(v1tag, { path: '/object/parents/0/message' }), 'Parent of tagged commit:')
+  await logResult(() => ipfs.dag.get(v1tag, { path: '/object/tree/src/hash/hello/hash' }), '/src/hello file:')
+  await logResult(() => ipfs.dag.get(v1tag, { path: '/object/parents/0/tree/src/hash/hello/hash' }), 'previous version of /src/hello file:')
 }
 
 main()

packages/interface-ipfs-core/src/dag/get.js

@@ -146,10 +146,8 @@ module.exports = (common, options) => {
       expect(cid).to.eql(cidCbor)
     })
 
-    it('should get by CID string + path', async function () {
-      const cidCborStr = cidCbor.toBaseEncodedString()
-
-      const result = await ipfs.dag.get(cidCborStr + '/pb/Data')
+    it('should get by CID with path option', async function () {
+      const result = await ipfs.dag.get(cidCbor, { path: '/pb/Data' })
       expect(result.value).to.eql(uint8ArrayFromString('I am inside a Protobuf'))
     })
 

packages/ipfs-core/src/components/dag/get.js

@@ -14,16 +14,7 @@ module.exports = ({ ipld, preload }) => {
   /**
    * @type {import('ipfs-core-types/src/dag').API["get"]}
    */
-  const get = async function get (ipfsPath, options = {}) {
-    const {
-      cid,
-      path
-    } = toCidAndPath(ipfsPath)
-
-    if (path) {
-      options.path = path
-    }
-
+  const get = async function get (cid, options = {}) {
     if (options.preload !== false) {
       preload(cid)
     }