This repository was archived by the owner on Feb 12, 2024. It is now read-only.
go-ipfs returns success when pinging with unknow peer id #2186
Assignees
Labels
exp/expert
Having worked on the specific codebase is important
P1
High: Likely tackled by core team if no one steps up
Comments
hugomrdias
added
exp/expert
|
@Stebalien any clue on what changed? |
|
We switched to returning an actual error so the command would exit with a non-zero exit status on failure. Bug: ipfs/kubo#6298 |
|
Closing as we are not maintaining compatibility with the Kubo API in future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
go ipfs version 0.4.21
https://github.com/ipfs/interface-js-ipfs-core/blob/master/src/ping/ping-pull-stream.js#L62
https://github.com/ipfs/interface-js-ipfs-core/blob/master/src/ping/ping-readable-stream.js#L70
https://github.com/ipfs/interface-js-ipfs-core/blob/master/src/ping/ping.js#L55
These tests are skipped in http-client until we find what changed and either fix the problem or replicate here in js-ipfs.
The text was updated successfully, but these errors were encountered: