Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

jsipfs ping $peerid buffers its output #2493

Closed
achingbrain opened this issue Sep 26, 2019 · 2 comments
Closed

jsipfs ping $peerid buffers its output #2493

achingbrain opened this issue Sep 26, 2019 · 2 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met status/ready Ready to be worked topic/perf Performance

Comments

@achingbrain
Copy link
Member

It should print the results as they come in like regular iputils ping instead of buffering them all up and printing them at the end.
@achingbrain achingbrain changed the title jsipfs ping $peerid buffers it's output jsipfs ping $peerid buffers its output Sep 26, 2019
@daviddias daviddias added the kind/bug A bug in existing code (including security flaws) label Oct 1, 2019
@alanshaw alanshaw added status/blocked Unable to be worked further until needs are met exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now topic/perf Performance status/ready Ready to be worked labels Oct 21, 2019
@alanshaw
Copy link
Member

Lets make sure we fix this as we propogate the async iterators refactor through the code base.

@alanshaw
Copy link
Member

resolved in #2726

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met status/ready Ready to be worked topic/perf Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alanshaw @achingbrain @daviddias