Skip to content

Commit 1eb94e6

Browse files
Merge pull request #2990 from csasarak/janky_version
Alias 'ipfs --version' to 'ipfs version'
2 parents 813bcb6 + 5e9cbd7 commit 1eb94e6

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

cmd/ipfs/main.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,13 @@ func main() {
103103
}
104104

105105
// Handle `ipfs help'
106-
if len(os.Args) == 2 && os.Args[1] == "help" {
107-
printHelp(false, os.Stdout)
108-
os.Exit(0)
106+
if len(os.Args) == 2 {
107+
if os.Args[1] == "help" {
108+
printHelp(false, os.Stdout)
109+
os.Exit(0)
110+
} else if os.Args[1] == "--version" {
111+
os.Args[1] = "version"
112+
}
109113
}
110114

111115
// parse the commandline into a command invocation

test/sharness/t0010-basic-commands.sh

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,24 @@ test_expect_success "ipfs version succeeds" '
1616
ipfs version >version.txt
1717
'
1818

19+
test_expect_success "ipfs --version success" '
20+
ipfs --version ||
21+
test_fsh ipfs --version
22+
'
23+
1924
test_expect_success "ipfs version output looks good" '
2025
egrep "^ipfs version [0-9]+\.[0-9]+\.[0-9]" version.txt >/dev/null ||
2126
test_fsh cat version.txt
2227
'
2328

29+
test_expect_success "ipfs versions matches ipfs --version" '
30+
ipfs version > version.txt &&
31+
ipfs --version > version2.txt &&
32+
diff version2.txt version.txt ||
33+
test_fsh ipfs --version
34+
35+
'
36+
2437
test_expect_success "ipfs version --all has all required fields" '
2538
ipfs version --all > version_all.txt &&
2639
grep "go-ipfs version" version_all.txt &&

0 commit comments

Comments
 (0)