Skip to content

Add 2px margin to all widgets but containers #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2015
Merged

Add 2px margin to all widgets but containers #216

merged 3 commits into from
Oct 30, 2015

Conversation

SylvainCorlay
Copy link
Member

  • Adding missing semantic css classes to widgets
  • Give a default margin of 2px to all widgets but containers (hbox, vbox, proxy).

@SylvainCorlay
Copy link
Member Author

@ellisonbg

jdfreder
jdfreder reviewed Oct 29, 2015
View reviewed changes
ipywidgets/static/widgets/js/widget_bool.js
@@ -16,7 +16,7 @@ define([
* Called when view is rendered.
*/
this.$el
.addClass('widget-hbox widget-checkbox');
.addClass('ipy-widget widget-hbox widget-checkbox');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think ipywidget would make more sense, since that's the name of the repo, no?

@SylvainCorlay SylvainCorlay force-pushed the margins branch 3 times, most recently from ed7cd3d to 3ab38ad Compare October 30, 2015 03:25
@SylvainCorlay
Copy link
Member Author

This is ready. Some examples checking the margins and alignments with nested VBox and HBox https://gist.github.com/SylvainCorlay/5d4632fe274840222827

@ellisonbg
Copy link
Member

Great, merging. We can iterate if we find any edge cases.

ellisonbg added a commit that referenced this pull request Oct 30, 2015
@ellisonbg
Merge pull request #216 from SylvainCorlay/margins
424f171 
Add 2px margin to all widgets but containers
@ellisonbg ellisonbg merged commit 424f171 into jupyter-widgets:master Oct 30, 2015
@SylvainCorlay SylvainCorlay deleted the margins branch October 30, 2015 15:24
@jdfreder jdfreder modified the milestone: 5.0 Oct 30, 2015
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature request resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SylvainCorlay @ellisonbg @jdfreder