Skip to content

Commit c701dc0

Browse files
committed
no need for union dynamic default
1 parent 8cb5ff5 commit c701dc0

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,4 @@ __pycache__
1717
\#*#
1818
.#*
1919
.coverage
20+
.cache/v/cache/lastfailed

traitlets/tests/test_traitlets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1488,7 +1488,7 @@ class UnionListTrait(HasTraits):
14881488

14891489
value = List(Int() | Bool())
14901490

1491-
class TestUnionListTrait(HasTraits):
1491+
class TestUnionListTrait(TraitTestBase):
14921492

14931493
obj = UnionListTrait()
14941494

traitlets/traitlets.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1820,15 +1820,6 @@ def __or__(self, other):
18201820
else:
18211821
return Union(self.trait_types + [other])
18221822

1823-
def make_dynamic_default(self):
1824-
if self.default_value is not Undefined:
1825-
return self.default_value
1826-
for trait_type in self.trait_types:
1827-
if trait_type.default_value is not Undefined:
1828-
return trait_type.default_value
1829-
elif hasattr(trait_type, 'make_dynamic_default'):
1830-
return trait_type.make_dynamic_default()
1831-
18321823

18331824
#-----------------------------------------------------------------------------
18341825
# Basic TraitTypes implementations/subclasses

0 commit comments

Comments
 (0)