patch process exists for windows machines #5577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
approved these changes
Jun 19, 2024
mattseddon
force-pushed
the
patch-process-exists
branch
from
f7c57ea to
5782a2d
Compare
|
Code Climate has analyzed commit 5782a2d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 75.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to solve the issues detailed here: https://discord.com/channels/485586884165107732/1250736030806446192
From https://github.com/MarkTiedemann/fastlist -> fastlist was originally built for use in sindresorhus/ps-list (see sindresorhus/ps-list#20). We use
process-existsthat usesps-list. It looks like the required binary is no longer packaged when we runvsce. Rather than try and dig through the dependencies I've just added a patch.