Skip to content

Commit 82451ce

Browse files
SimonSapinivanzr
authored andcommitted
Revert URL setter test spec deviations for now
See web-platform-tests#2830 (comment). This can be un-reverted when the following are fixed in the spec: - whatwg/url#113 - whatwg/url#104
1 parent 2fcdf93 commit 82451ce

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

url/setters_tests.json

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,12 @@
102102
}
103103
},
104104
{
105-
"comment": "Spec deviation: from special scheme to not is not problematic. https://github.com/whatwg/url/issues/104",
105+
"comment": "Can’t switch from special scheme to non-special. Note: this may change, see https://github.com/whatwg/url/issues/104",
106106
"href": "http://example.net",
107107
"new_value": "b",
108108
"expected": {
109-
"href": "b://example.net/",
110-
"protocol": "b:"
109+
"href": "http://example.net/",
110+
"protocol": "http:"
111111
}
112112
},
113113
{
@@ -120,12 +120,12 @@
120120
}
121121
},
122122
{
123-
"comment": "Spec deviation: from non-special scheme with a host to special is not problematic. https://github.com/whatwg/url/issues/104",
123+
"comment": "Can’t switch from non-special scheme to special. Note: this may change, see https://github.com/whatwg/url/issues/104",
124124
"href": "ssh://[email protected]",
125125
"new_value": "http",
126126
"expected": {
127-
"href": "http://[email protected]/",
128-
"protocol": "http:"
127+
"href": "ssh://[email protected]/",
128+
"protocol": "ssh:"
129129
}
130130
},
131131
{
@@ -346,14 +346,14 @@
346346
}
347347
},
348348
{
349-
"comment": "Spec deviation: port number is removed if empty in the new value: https://github.com/whatwg/url/pull/113",
349+
"comment": "Port number is unchanges if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113",
350350
"href": "http://example.net:8080",
351351
"new_value": "example.com:",
352352
"expected": {
353-
"href": "http://example.com/",
354-
"host": "example.com",
353+
"href": "http://example.com:8080/",
354+
"host": "example.com:8080",
355355
"hostname": "example.com",
356-
"port": ""
356+
"port": "8080"
357357
}
358358
},
359359
{
@@ -761,14 +761,14 @@
761761
}
762762
},
763763
{
764-
"comment": "Spec deviation: port number is removed if empty in the new value. https://github.com/whatwg/url/pull/113",
764+
"comment": "Port number is unchanged if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113",
765765
"href": "http://example.net:8080",
766766
"new_value": "",
767767
"expected": {
768-
"href": "http://example.net/",
769-
"host": "example.net",
768+
"href": "http://example.net:8080/",
769+
"host": "example.net:8080",
770770
"hostname": "example.net",
771-
"port": ""
771+
"port": "8080"
772772
}
773773
},
774774
{

0 commit comments

Comments
 (0)