Disable wheel usage only on single package instead of whole session, fix for pypa#4118

Author: ibriquem

src/pip/_internal/req/req_file.py

@@ -4,6 +4,7 @@
 
 from __future__ import absolute_import
 
+import copy
 import optparse
 import os
 import re
@@ -128,8 +129,8 @@ def process_line(line, filename, line_number, finder=None, comes_from=None,
     defaults = parser.get_default_values()
     defaults.index_url = None
     if finder:
-        # `finder.format_control` will be updated during parsing
-        defaults.format_control = finder.format_control
+        # `finder.format_control` should be local to each line
+        defaults.format_control = copy.deepcopy(finder.format_control)
     args_str, options_str = break_args_options(line)
     if sys.version_info < (2, 7, 3):
         # Prior to 2.7.3, shlex cannot deal with unicode entries
@@ -144,8 +145,8 @@ def process_line(line, filename, line_number, finder=None, comes_from=None,
     # yield a line requirement
     if args_str:
         isolated = options.isolated_mode if options else False
-        if options:
-            cmdoptions.check_install_build_global(options, opts)
+        if opts:
+            cmdoptions.check_install_build_global(opts, opts)
         # get the options that apply to requirements
         req_options = {}
         for dest in SUPPORTED_OPTIONS_REQ_DEST:
@@ -217,6 +218,8 @@ def process_line(line, filename, line_number, finder=None, comes_from=None,
         if opts.trusted_hosts:
             finder.secure_origins.extend(
                 ("*", host, "*") for host in opts.trusted_hosts)
+        if options:
+            cmdoptions.check_install_build_global(options, opts)
 
 
 def break_args_options(line):

tests/data/packages/README.txt

@@ -113,3 +113,7 @@ require_simple-1.0.tar.gz
 ------------------------
 contains "require_simple" package which requires simple>=2.0 - used for testing
 if dependencies are handled correctly.
+
+wheel_only*
+-----------
+A package which fails to install from source, but can be installed from wheel (simulates a prebuilt binary package with missing include files).

tests/data/packages/wheel_only-1.0-py3-none-any.whl

@@ -0,0 +1,5 @@
+[egg_info]
+tag_build = 
+tag_date = 0
+tag_svn_revision = 0
+

tests/data/packages/wheel_only-1.0.tar.gz

@@ -0,0 +1,13 @@
+#!/usr/bin/env python
+from setuptools import setup, find_packages
+import os
+
+# This simulates a requirement which is not necessary in the wheel
+# But needed if building from source
+if 'BUILDING_WHEEL' not in os.environ:
+    raise Exception("Fake build error")
+
+setup(name='wheel_only',
+      version='1.0',
+      packages=find_packages()
+      )

tests/data/src/wheel_only/setup.cfg

@@ -547,3 +547,22 @@ def test_install_options_local_to_package(script, data):
     assert bad not in result.files_created
     assert good in result.files_created
     assert result.files_created[good].dir
+
+
+def test_install_options_does_not_disable_wheels(script, data):
+    """Make sure --install-options disable wheel usage for other packages."""
+    home_simple = script.scratch_path.join("for-simple")
+    home_simple.mkdir()
+    reqs_file = script.scratch_path.join("reqs.txt")
+    reqs_file.write(
+        textwrap.dedent("""
+            simple --install-option='--home=%s'
+            wheel-only
+            """ % home_simple))
+    result = script.pip(
+        'install',
+        '--no-index', '-f', data.find_links,
+        '-r', reqs_file,
+        expect_error=False,
+        expect_stderr=True,
+    )