Skip to content

Get codebase building pre bundling #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Get codebase building pre bundling #17

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Sep 7, 2022 •
edited
Loading

This isn't totally complete, but enough to get everything building and
tests running manually. The next commit will make the build work fully.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling (this PR)
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 5360203 to 2ac243c Compare September 13, 2022 16:52
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 4776832 to 0b8b109 Compare September 13, 2022 16:52
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 2ac243c to 70d9433 Compare September 13, 2022 20:27
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 0b8b109 to 9890b10 Compare September 13, 2022 20:28
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 70d9433 to 928ab66 Compare September 13, 2022 21:03
@jakebailey jakebailey changed the title Hand convert non-JSDoc at-internal comments Fix all internal JSDoc comments Sep 13, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 9890b10 to d768606 Compare September 13, 2022 21:03
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 928ab66 to 867a2aa Compare September 13, 2022 21:47
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from d768606 to cf88621 Compare September 13, 2022 21:47
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 867a2aa to 1254f1a Compare September 13, 2022 21:58
@jakebailey jakebailey changed the title Fix all internal JSDoc comments Ensure emitted d.ts files do not contain extraneous import expressions Sep 13, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from cf88621 to b4dd985 Compare September 13, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 1254f1a to 97aa3be Compare September 13, 2022 23:22
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from b4dd985 to 594728a Compare September 13, 2022 23:22
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 97aa3be to d668e08 Compare September 14, 2022 17:26
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 594728a to f07182a Compare September 14, 2022 17:26
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from d668e08 to 28e85d5 Compare September 16, 2022 04:36
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from f07182a to 8187c8b Compare September 16, 2022 04:36
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 28e85d5 to 71704b8 Compare September 16, 2022 04:37
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 8187c8b to dd3c92a Compare September 16, 2022 04:37
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 71704b8 to ee9fbc7 Compare September 16, 2022 05:43
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from dd3c92a to a64011e Compare September 16, 2022 05:43
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from ee9fbc7 to b8eeb40 Compare September 19, 2022 20:11
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from a64011e to 72bcb7d Compare September 19, 2022 20:11
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from b8eeb40 to 1e25093 Compare September 19, 2022 20:38
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 72bcb7d to 6db765e Compare September 19, 2022 20:38
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 1e25093 to bf0399d Compare September 20, 2022 05:06
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 6db765e to 89a75d5 Compare September 20, 2022 05:06
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from bf0399d to f226b70 Compare September 20, 2022 05:10
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 89a75d5 to 8ce2c5c Compare September 20, 2022 05:11
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 08e54b2 to 21e4fad Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from a59c58c to ee65f9b Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 21e4fad to 7f6e832 Compare October 27, 2022 04:22
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from ee65f9b to 5302707 Compare October 27, 2022 04:23
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 7f6e832 to 15b44e9 Compare October 27, 2022 17:40
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 5302707 to 6ee719a Compare October 27, 2022 17:41
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 15b44e9 to 3ef80ba Compare October 28, 2022 02:23
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 6ee719a to fa26911 Compare October 28, 2022 02:23
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 3ef80ba to d540ba9 Compare October 31, 2022 21:33
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from fa26911 to 5e7fc79 Compare October 31, 2022 21:34
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from d540ba9 to 0adff62 Compare November 2, 2022 00:44
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 5e7fc79 to 0749b20 Compare November 2, 2022 00:44
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 0adff62 to 596aa81 Compare November 2, 2022 16:55
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 0749b20 to 2718cbf Compare November 2, 2022 16:56
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 596aa81 to 2162bb4 Compare November 2, 2022 19:46
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 2718cbf to 77fb04e Compare November 2, 2022 19:46
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 2162bb4 to e1dc651 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 77fb04e to 0f31519 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from e1dc651 to ab93880 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 0f31519 to 760ae38 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from ab93880 to 74adea3 Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 760ae38 to 73d6fd0 Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from 74adea3 to d3555dd Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 73d6fd0 to 56a4606 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-15 branch from d3555dd to 28609b5 Compare November 7, 2022 21:38
@jakebailey
Get codebase building pre bundling
248fbdc 
This isn't totally complete, but enough to get everything building and
tests running manually. The next commit will make the build work fully.
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 56a4606 to 248fbdc Compare November 7, 2022 21:38
@jakebailey jakebailey deleted the branch transform-stack-commit-15 November 7, 2022 23:54
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-16 branch November 7, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey