Tests

Author: MikhailArkhipov

src/Analysis/Ast/Impl/Analyzer/PythonAnalyzer.cs

@@ -227,8 +227,14 @@ private async Task AnalyzeAffectedEntriesAsync(IDependencyChainWalker<ModuleKey,
                     StartAnalysis(node, walker.Version, stopWatch, cancellationToken);
                 }
             }
-            
-            if (walker.MissingKeys.Where(k => !k.IsTypeshed).Count == 0) {
+
+            var count = walker.MissingKeys.Where(k => !k.IsTypeshed).Count;
+            _log?.Log(TraceEventType.Verbose, $"Walker count is {count}, missing keys:");
+            foreach (var key in walker.MissingKeys) {
+                _log?.Log(TraceEventType.Verbose, $"    Name: {key.Name}, Path: {key.FilePath}");
+            }
+
+            if (count == 0) {
                 Interlocked.Exchange(ref _runningTasks, 0);
                 _analysisCompleteEvent.Set();
             }

src/Analysis/Ast/Impl/Modules/PythonModule.cs

@@ -111,6 +111,7 @@ internal PythonModule(ModuleCreationOptions creationOptions, IServiceContainer s
                 ContentState = State.Analyzed;
             }
             InitializeContent(creationOptions.Content);
+            Log?.Log(TraceEventType.Verbose, $"Created module: {Name} {FilePath}");
         }
 
         #region IPythonType
@@ -385,21 +386,16 @@ private void Parse(CancellationToken cancellationToken) {
                     _diagnosticsService?.Replace(Uri, _parseErrors);
                 }
 
-                ContentState = State.Parsed;
-            }
-
-            NewAst?.Invoke(this, EventArgs.Empty);
-
-            if (ContentState < State.Analyzing) {
                 ContentState = State.Analyzing;
 
+                Log?.Log(TraceEventType.Verbose, $"Enqueue: {Name} {FilePath}");
                 var analyzer = Services.GetService<IPythonAnalyzer>();
                 analyzer.EnqueueDocumentForAnalysis(this, ast, version, _allProcessingCts.Token);
-            }
 
-            lock (AnalysisLock) {
                 _parsingTask = null;
             }
+
+            NewAst?.Invoke(this, EventArgs.Empty);
         }
 
         private class CollectingErrorSink : ErrorSink {

src/Analysis/Ast/Test/BasicTests.cs

@@ -75,12 +75,14 @@ public async Task ImportTest() {
 import sys
 x = sys.path
 ";
-            var analysis = await GetAnalysisAsync(code);
-            analysis.GlobalScope.Variables.Count.Should().Be(2);
-
-            analysis.Should()
-                .HaveVariable("sys").OfType(BuiltinTypeId.Module)
-                .And.HaveVariable("x").OfType(BuiltinTypeId.List);
+            for (var i = 0; i < 20; i++) {
+                var analysis = await GetAnalysisAsync(code);
+                analysis.GlobalScope.Variables.Count.Should().Be(2);
+
+                analysis.Should()
+                    .HaveVariable("sys").OfType(BuiltinTypeId.Module)
+                    .And.HaveVariable("x").OfType(BuiltinTypeId.List);
+            }
         }
 
         [TestMethod, Priority(0)]