15 * time.Second * time.Second causes an int64 overflow and httpserver fails without any error log. Issue:golang/go#39177

Author: Hadi Jalilzade

cmd/server/main.go

@@ -3,7 +3,6 @@ package main
 import (
 	"flag"
 	"fmt"
-	"time"
 )
 
 func main() {
@@ -19,10 +18,15 @@ func main() {
 
 	config := &ServerConfig{
 		Address:      fmt.Sprintf("%s:%d", *ip, *port),
-		WriteTimeout: 15 * time.Second,
-		ReadTimeout:  15 * time.Second,
+		WriteTimeout: 15,
+		ReadTimeout:  15,
+	}
+
+	srv, err := NewServer(config)
+	if err != nil {
+		fmt.Println(err)
+		return
 	}
 
-	srv := NewServer(config)
 	srv.start()
 }

cmd/server/server.go

@@ -1,8 +1,9 @@
 package main
 
 import (
-	"encoding/json"
+	"errors"
 	"fmt"
+	"math"
 	"net/http"
 	"time"
 
@@ -17,34 +18,38 @@ type Server struct {
 }
 
 //NewServer is to create httpserver
-func NewServer(config *ServerConfig) *Server {
+func NewServer(config *ServerConfig) (*Server, error) {
 	// todo: Create HttppServer
 
 	router := mux.NewRouter()
 	registerRouters(router)
-	router.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
-		// an example API handler
-		json.NewEncoder(w).Encode(map[string]bool{"ok": true})
-	})
+
+	//Check for Int64 Overflow
+	if math.MaxInt64/time.Second < config.WriteTimeout {
+		return nil, errors.New("WriteTimeout overflows int64")
+	}
+
+	if math.MaxInt64/time.Second < config.ReadTimeout {
+		return nil, errors.New("ReadTimeout overflows int64")
+	}
 
 	server := &Server{
 		config: config,
 		router: router,
+		httpServer: &http.Server{
+			Handler:      router,
+			Addr:         config.Address,
+			WriteTimeout: config.WriteTimeout * time.Second,
+			ReadTimeout:  config.ReadTimeout * time.Second,
+		},
 	}
 
-	server.httpServer = &http.Server{
-		Handler:      router,
-		Addr:         config.Address,
-		WriteTimeout: config.WriteTimeout * time.Second,
-		ReadTimeout:  config.ReadTimeout * time.Second,
-	}
-
-	return server
+	return server, nil
 }
 
 func (s *Server) start() error {
 	// todo: Start and Listen HttpServer
-	fmt.Printf("Listening on %s \n", s.httpServer.Addr)
+	fmt.Printf("Listening on http://%s \n", s.httpServer.Addr)
 	return s.httpServer.ListenAndServe()
 }