Skip to content

Commit 9725bd2

Browse files
authored
Merge pull request #308 from jamesls/no-async-generator
Remove use of async_generator from tests
2 parents 2d267e7 + bb9a44f commit 9725bd2

File tree

5 files changed

+13
-22
lines changed

5 files changed

+13
-22
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ jobs:
6363
- run: pip install .
6464
if: ${{ matrix.coverage != 'yes' }}
6565
- run: flake8
66-
- run: pytest --cov=fakeredis --cov-branch
66+
- run: pytest -v --cov=fakeredis --cov-branch
6767
if: ${{ matrix.coverage == 'yes' }}
68-
- run: pytest
68+
- run: pytest -v
6969
if: ${{ matrix.coverage != 'yes' }}
7070
- run: coveralls --service=github
7171
env:

requirements.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
aioredis
2-
async_generator
32
coverage
43
flake8
54
hypothesis

requirements.txt

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
#
2-
# This file is autogenerated by pip-compile
2+
# This file is autogenerated by pip-compile with python 3.8
33
# To update, run:
44
#
55
# pip-compile requirements.in
66
#
77
aioredis==1.3.1
88
# via -r requirements.in
9-
async-generator==1.10
10-
# via -r requirements.in
119
async-timeout==3.0.1
1210
# via aioredis
1311
attrs==20.3.0
@@ -42,18 +40,18 @@ pyflakes==2.2.0
4240
# via flake8
4341
pyparsing==2.4.7
4442
# via packaging
45-
pytest-asyncio==0.14.0
46-
# via -r requirements.in
47-
pytest-cov==2.10.1
48-
# via -r requirements.in
49-
pytest-mock==3.3.1
50-
# via -r requirements.in
5143
pytest==6.1.2
5244
# via
5345
# -r requirements.in
5446
# pytest-asyncio
5547
# pytest-cov
5648
# pytest-mock
49+
pytest-asyncio==0.15.1
50+
# via -r requirements.in
51+
pytest-cov==2.10.1
52+
# via -r requirements.in
53+
pytest-mock==3.3.1
54+
# via -r requirements.in
5755
redis==3.5.3
5856
# via -r requirements.in
5957
six==1.15.0

test/test_aioredis1.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
from packaging.version import Version
44
import pytest
55
import aioredis
6-
from async_generator import yield_, async_generator
76

87
import fakeredis.aioredis
98

@@ -21,7 +20,6 @@
2120
pytest.param('real', marks=pytest.mark.real)
2221
]
2322
)
24-
@async_generator
2523
async def r(request):
2624
if request.param == 'fake':
2725
ret = await fakeredis.aioredis.create_redis_pool()
@@ -31,19 +29,18 @@ async def r(request):
3129
ret = await aioredis.create_redis_pool('redis://localhost')
3230
await ret.flushall()
3331

34-
await yield_(ret)
32+
yield ret
3533

3634
await ret.flushall()
3735
ret.close()
3836
await ret.wait_closed()
3937

4038

4139
@pytest.fixture
42-
@async_generator
4340
async def conn(r):
4441
"""A single connection, rather than a pool."""
4542
with await r as conn:
46-
await yield_(conn)
43+
yield conn
4744

4845

4946
async def test_ping(r):

test/test_aioredis2.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import pytest
66
import aioredis
77
import async_timeout
8-
from async_generator import yield_, async_generator
98

109
import fakeredis.aioredis
1110

@@ -28,7 +27,6 @@
2827
pytest.param('real', marks=pytest.mark.real)
2928
]
3029
)
31-
@async_generator
3230
async def r(request):
3331
if request.param == 'fake':
3432
fake_server = request.getfixturevalue('fake_server')
@@ -41,19 +39,18 @@ async def r(request):
4139
if not fake_server or fake_server.connected:
4240
await ret.flushall()
4341

44-
await yield_(ret)
42+
yield ret
4543

4644
if not fake_server or fake_server.connected:
4745
await ret.flushall()
4846
await ret.connection_pool.disconnect()
4947

5048

5149
@pytest.fixture
52-
@async_generator
5350
async def conn(r):
5451
"""A single connection, rather than a pool."""
5552
async with r.client() as conn:
56-
await yield_(conn)
53+
yield conn
5754

5855

5956
async def test_ping(r):

0 commit comments

Comments
 (0)