[COFF] Enable new passmanager plugin support for LTO

Author: jamesmth

lld/COFF/Config.h

@@ -151,6 +151,8 @@ struct Configuration {
   llvm::SmallString<128> pdbPath;
   llvm::SmallString<128> pdbSourcePath;
   std::vector<llvm::StringRef> argv;
+  std::vector<std::string> passPlugins;
+  llvm::StringRef ltoNewPmPasses;
 
   // Symbols in this set are considered as live by the garbage collector.
   std::vector<Symbol *> gcroot;

lld/COFF/Driver.cpp

@@ -1945,6 +1945,11 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
     }
   }
 
+  if (args.hasArg(OPT_load_pass_plugins))
+    config->passPlugins = args.getAllArgValues(OPT_load_pass_plugins);
+
+  config->ltoNewPmPasses = args.getLastArgValue(OPT_lto_newpm_passes);
+
   if (!icfLevel)
     icfLevel = doGC ? ICFLevel::All : ICFLevel::None;
   config->doGC = doGC;

lld/COFF/LTO.cpp

@@ -102,6 +102,12 @@ lto::Config BitcodeCompiler::createConfig() {
     c.Options.MCOptions.AsmVerbose = true;
   }
 
+  for (const std::string& pluginFn : ctx.config.passPlugins)
+    c.PassPlugins.push_back(pluginFn);
+
+  // Set up a custom pipeline if we've been asked to.
+  c.OptPipeline = std::string(ctx.config.ltoNewPmPasses);
+
   if (!ctx.config.saveTempsArgs.empty())
     checkError(c.addSaveTemps(std::string(ctx.config.outputFile) + ".",
                               /*UseInputModulePath*/ true,

lld/COFF/Options.td

@@ -328,6 +328,9 @@ def map_info : P<"mapinfo", "Include the specified information in a map file">;
 def print_search_paths : F<"print-search-paths">;
 def summary : F<"summary">;
 
+def load_pass_plugins: P<"load-pass-plugin", "Load passes from plugin library">;
+def lto_newpm_passes: P<"lto-newpm-passes", "Passes to run during LTO">;
+
 //==============================================================================
 // The flags below do nothing. They are defined only for link.exe compatibility.
 //==============================================================================

llvm/CMakeLists.txt

@@ -59,6 +59,10 @@ set(LLVM_LIBDIR_SUFFIX "" CACHE STRING "Define suffix of library directory name
 # Must go after `project(..)`.
 include(GNUInstallDirs)
 
+if (LLVM_EXPORT_SYMBOLS_FOR_PLUGINS)
+  add_definitions(-DEXPORT_SYMBOLS)
+endif()
+
 # This C++ standard is required to build LLVM.
 set(LLVM_REQUIRED_CXX_STANDARD 17)
 

llvm/include/llvm/IR/Analysis.h

@@ -14,6 +14,24 @@
 
 #include "llvm/ADT/SmallPtrSet.h"
 
+#ifdef _WIN32
+  #define DLL_EXPORT __declspec(dllexport)
+#else
+  #define DLL_EXPORT
+#endif
+
+#ifdef _WIN32
+  #define DLL_IMPORT __declspec(dllimport)
+#else
+  #define DLL_IMPORT
+#endif
+
+#ifdef EXPORT_SYMBOLS
+  #define DLL_API DLL_EXPORT
+#else
+  #define DLL_API DLL_IMPORT
+#endif
+
 namespace llvm {
 
 class Function;
@@ -51,7 +69,7 @@ template <typename IRUnitT> class AllAnalysesOn {
   static AnalysisSetKey *ID() { return &SetKey; }
 
 private:
-  static AnalysisSetKey SetKey;
+  DLL_API static AnalysisSetKey SetKey;
 };
 
 template <typename IRUnitT> AnalysisSetKey AllAnalysesOn<IRUnitT>::SetKey;
@@ -300,7 +318,7 @@ class PreservedAnalyses {
 
 private:
   /// A special key used to indicate all analyses.
-  static AnalysisSetKey AllAnalysesKey;
+  DLL_API static AnalysisSetKey AllAnalysesKey;
 
   /// The IDs of analyses and analysis sets that are preserved.
   SmallPtrSet<void *, 2> PreservedIDs;

llvm/include/llvm/IR/PassManager.h

@@ -54,6 +54,24 @@
 #include <utility>
 #include <vector>
 
+#ifdef _WIN32
+  #define DLL_EXPORT __declspec(dllexport)
+#else
+  #define DLL_EXPORT
+#endif
+
+#ifdef _WIN32
+  #define DLL_IMPORT __declspec(dllimport)
+#else
+  #define DLL_IMPORT
+#endif
+
+#ifdef EXPORT_SYMBOLS
+  #define DLL_API DLL_EXPORT
+#else
+  #define DLL_API DLL_IMPORT
+#endif
+
 namespace llvm {
 
 class Function;
@@ -507,7 +525,7 @@ template <typename IRUnitT, typename... ExtraArgTs> class AnalysisManager {
   }
 
   /// Get an analysis result, running the pass if necessary.
-  ResultConceptT &getResultImpl(AnalysisKey *ID, IRUnitT &IR,
+  DLL_API ResultConceptT &getResultImpl(AnalysisKey *ID, IRUnitT &IR,
                                 ExtraArgTs... ExtraArgs);
 
   /// Get a cached analysis result or return null.
@@ -634,7 +652,7 @@ class InnerAnalysisManagerProxy
   friend AnalysisInfoMixin<
       InnerAnalysisManagerProxy<AnalysisManagerT, IRUnitT>>;
 
-  static AnalysisKey Key;
+  DLL_API static AnalysisKey Key;
 
   AnalysisManagerT *InnerAM;
 };