ProductUpgrader: copy whole upgrade application

When upgrading VFS for Git via the built-in upgrade logic, the upgrade verb
will copy the upgrader application to a temporary directory, and run the
upgrade app from the temporary directory. The main reason for this is so that
the upgrade application can update the original application without open file
handles getting in the way (and preventing the deletion of the application that
is being updated).

The upgrade verb currently has a hard coded list of dependencies (files)
required for the upgrader application to run. This can be fragile as we need to
keep this list in sync with the actual dependencies, across multiple platforms.
This can easily break if the dependencies change, and we update the list of
files included with the installer, but not with the upgrader application. A
specific occurrence of this happened in microsoft#1144.

Instead, just copy over the whole VFS for Git application directory when
creating a temporary copy of the upgrader application to run. We might copy
over a few additional files, but this should not cause any noticeable
downsides.

Author: jamill

GVFS/GVFS.Common/ProductUpgrader.cs

@@ -29,27 +29,6 @@ public abstract class ProductUpgrader : IDisposable
 
         private const string ToolsDirectory = "Tools";
         private static readonly string UpgraderToolName = GVFSPlatform.Instance.Constants.GVFSUpgraderExecutableName;
-        private static readonly string UpgraderToolConfigFile = UpgraderToolName + ".config";
-        private static readonly string[] UpgraderToolAndLibs =
-            {
-                UpgraderToolName,
-                UpgraderToolConfigFile,
-                "GVFS.Common.dll",
-                "GVFS.Platform.Windows.dll",
-                "netstandard.dll",
-                "System.Net.Http.dll",
-                "Newtonsoft.Json.dll",
-                "CommandLine.dll",
-                "NuGet.Commands.dll",
-                "NuGet.Common.dll",
-                "NuGet.Configuration.dll",
-                "NuGet.Frameworks.dll",
-                "NuGet.Packaging.Core.dll",
-                "NuGet.Packaging.dll",
-                "NuGet.Protocol.dll",
-                "NuGet.Versioning.dll",
-                "System.IO.Compression.dll"
-            };
 
         public ProductUpgrader(
             string currentVersion,
@@ -196,29 +175,21 @@ public virtual bool TrySetupToolsDirectory(out string upgraderToolPath, out stri
 
             string currentPath = ProcessHelper.GetCurrentProcessLocation();
             error = null;
-            foreach (string name in UpgraderToolAndLibs)
+            try
             {
-                string toolPath = Path.Combine(currentPath, name);
-                string destinationPath = Path.Combine(toolsDirectoryPath, name);
-                try
-                {
-                    this.fileSystem.CopyFile(toolPath, destinationPath, overwrite: true);
-                }
-                catch (UnauthorizedAccessException e)
-                {
-                    error = string.Join(
-                        Environment.NewLine,
-                        "File copy error - " + e.Message,
-                        $"Make sure you have write permissions to directory {toolsDirectoryPath} and run {GVFSConstants.UpgradeVerbMessages.GVFSUpgradeConfirm} again.");
-                    this.TraceException(e, nameof(this.TrySetupToolsDirectory), $"Error copying {toolPath} to {destinationPath}.");
-                    break;
-                }
-                catch (IOException e)
-                {
-                    error = "File copy error - " + e.Message;
-                    this.TraceException(e, nameof(this.TrySetupToolsDirectory), $"Error copying {toolPath} to {destinationPath}.");
-                    break;
-                }
+                this.fileSystem.CopyDirectoryRecursive(currentPath, toolsDirectoryPath);
+            }
+            catch (UnauthorizedAccessException e)
+            {
+                error = string.Join(
+                    Environment.NewLine,
+                    "File copy error - " + e.Message,
+                    $"Make sure you have write permissions to directory {toolsDirectoryPath} and run {GVFSConstants.UpgradeVerbMessages.GVFSUpgradeConfirm} again.");
+            }
+            catch (IOException e)
+            {
+                error = "File copy error - " + e.Message;
+                this.TraceException(e, nameof(this.TrySetupToolsDirectory), $"Error copying {currentPath} to {toolsDirectoryPath}.");
             }
 
             if (string.IsNullOrEmpty(error))