Skip to content

Commit f107731

Browse files
committed
Upgrader: do not include Micrsoft.Diagnostic.Tracing.EventSource
The upgrade verb attempts to copy Microsoft.Diagnostic.Tracing.EventSource when copying the ProductUpgrader to the temporary directory to run. If this file is not present, then the upgrade verb will fail. This following commit removes this file: cbe5787 ("Remove in-proc ETW trace event listener", 2019-02-18) Clean installs of VFS4G that include this commit will no longer have this file in the installation directory, and will not be able to upgrade. This dll is no longer needed or installed during installation, so we remove it from the list of files copied over for upgrade. This is a quick fix - we will also see how to make this less fragile. One option might be to install "upgrader app" into its own directory under the VFS For Git installation directory, and then just copy the directory to the temp location, instead of providing a list of files that need to be kept in sync.
1 parent 2258265 commit f107731

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

GVFS/GVFS.Common/ProductUpgrader.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ public abstract class ProductUpgrader : IDisposable
3636
UpgraderToolConfigFile,
3737
"GVFS.Common.dll",
3838
"GVFS.Platform.Windows.dll",
39-
"Microsoft.Diagnostics.Tracing.EventSource.dll",
4039
"netstandard.dll",
4140
"System.Net.Http.dll",
4241
"Newtonsoft.Json.dll",

0 commit comments

Comments
 (0)