From 4c0255d2d38d9fb4f69c949c245fccc307918761 Mon Sep 17 00:00:00 2001 From: Taylor Baldwin Date: Wed, 22 Jan 2025 10:51:41 -0500 Subject: [PATCH] python dist should be cleaned before building - also log when theres an error during python pkg upload --- releaser/src/package_manager/python/mod.rs | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/releaser/src/package_manager/python/mod.rs b/releaser/src/package_manager/python/mod.rs index 0b8d1d4a3..b46d9af3e 100644 --- a/releaser/src/package_manager/python/mod.rs +++ b/releaser/src/package_manager/python/mod.rs @@ -84,6 +84,9 @@ impl PackageManager for PythonPackageManager { let python = env.python(); + // clean dist directory + let _ = fs::remove_dir_all(path.join("dist")); + // Build the package let build_output = Command::new(python) .arg("-m") @@ -101,7 +104,7 @@ impl PackageManager for PythonPackageManager { } // Upload the package - Command::new(python) + let upload_output = Command::new(python) .arg("-m") .arg("twine") .arg("upload") @@ -109,6 +112,15 @@ impl PackageManager for PythonPackageManager { .current_dir(path) .output()?; + if !upload_output.status.success() { + return Err(anyhow::anyhow!( + "Upload failed with status: {}.\nStdout: {}\nStderr: {}", + upload_output.status, + String::from_utf8_lossy(&upload_output.stdout), + String::from_utf8_lossy(&upload_output.stderr) + )); + } + Ok(()) } }