Deprecate third and fourth parameter

Author: janlelis

CHANGELOG.md

@@ -22,6 +22,8 @@ Other:
 
 - Add keyword arguments to `Unicode::DisplayWidth.of`. If you are using a hash
   with overwrite value, be sure to put it in curly braces.
+- Using third parameter or explicit hash as fourth parameter is deprecated,
+  please migrate to the keyword arguments API
 - Gem raises ArgumentError for ambiguous values other than 1 or 2
 - Performance optimizations
 

lib/unicode/display_width.rb

@@ -35,7 +35,7 @@ class DisplayWidth
     # Returns monospace display width of string
     def self.of(string, ambiguous = nil, overwrite = nil, old_options = {}, **options)
       unless old_options.empty?
-        warn ArgumentError, "Unicode::DisplayWidth: Please migrate to keyword arguments: #{old_options.inspect}"
+        warn "Unicode::DisplayWidth: Please migrate to keyword arguments - #{old_options.inspect}"
         options.merge! old_options
       end
 
@@ -46,8 +46,8 @@ def self.of(string, ambiguous = nil, overwrite = nil, old_options = {}, **option
         raise ArgumentError, "Unicode::DisplayWidth: Ambiguous width must be 1 or 2"
       end
 
-      if overwrite
-        # warn "Unicode::DisplayWidth: Deprecated, please use overwrite: {} keyword options instead of passing overwrites as third parameter"
+      if overwrite && !overwrite.empty?
+        warn "Unicode::DisplayWidth: Please migrate to keyword arguments - overwrite: #{overwrite.inspect}"
         options[:overwrite] = overwrite
       end
       options[:overwrite] ||= {}