feat: drop same height requirement

jantimon · jantimon · commit 8f59298d7e6f · 2019-06-10T13:01:44.000+02:00
diff --git a/example/animation/dist/styles.css b/example/animation/dist/styles.css
@@ -1,17 +1,26 @@
-@font-face { font-family: Hacc2d; src:url(data:application/x-font-woff;charset=utf-8;base64,d09GRgABAAAAAAPwAAsAAAAABgAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAABHU1VCAAABCAAAADsAAABUIIslek9TLzIAAAFEAAAAQQAAAFY2Lz7PY21hcAAAAYgAAABKAAABcOEoo6pnbHlmAAAB1AAAAFgAAABYA2INqWhlYWQAAAIsAAAAMAAAADYUFQIQaGhlYQAAAlwAAAAbAAAAJAaXAttobXR4AAACeAAAAAgAAAAIAtgAAGxvY2EAAAKAAAAABgAAAAYALAAAbWF4cAAAAogAAAAeAAAAIAEOACNuYW1lAAACqAAAASkAAAIWm5e+CnBvc3QAAAPUAAAAGwAAACxqQQEEeJxjYGRgYOBiMGCwY2BycfMJYeDLSSzJY5BiYGGAAJA8MpsxJzM9kYEDxgPKsYBpDiBmg4gCACY7BUgAeJxjYGTMYZzAwMrAwHiOaQ8DA0MPhGZ8wGDIyMTAwMTAysyAFQSkuaYwODxgeMDA/ALIjQKSAkCaESQHAAPVC2oAAAB4nO2QsQ2AMBADz8pDgRiBKjWzULG/2CT5GNgils6ST189sAAlOZMA3YiRK63sC5t9UH0Twz+09nfucKOVmd19fMu/ekEdGiYJUQAAAAIAAP/wAq4CyQAEABYAABsBBSUTByEXIQ8BFSMvATMfAT8BISchLDoBBQEIOn/+zQcBJhekAqQKTwZZWgr+6RUBkwLJ/XFKSgKP1lL4LQEuf0AYGGjzAHicY2BkYGAA4nk9dbbx/DZfGbiZXwBFGG4q37dE0P8/MK1jOgnkcjAwgUQBTuQMGXicY2BkYGB+wQAETDfA5DoGRgZUwAQAPzACegAAAAAAAtgAAAAAAAAALAAAeJxjYGRgYGBiEAdiBjCLgYELCBkY/oP5DAAK7QEyAAB4nGWQPW7CQBSEx2BIAlKCFCkps1UKIpmfkgNAT0GXwpi1MbK91npBossJcoQcIaeIcoIcKGPzaGAtP38zb97uygAG+IWHenm4bWq9WrihOnGb9CDsk5+FO+jjRbhLfyjcwxumwn084p07eP4dnQFK4Rbu8SHcpv8p7JO/hDt4wrdwl/6PcA8r/An38eoN08gUsSncUif7LLRnef6utK1SU6hJMD5bC11oGzq9Ueujqg7J1LlYxdbkas6uzjKjSmt2OnLB1rlyNhrF4geRyZEigkGBuKkOS2gk2CNDCHvVvdQrpi0q+rVWmCDA+Cq1YKpokiGVxobJNY6sFQ48bUrXMa34Ws7kpLnMat4kIyv+77q3oxPRD7BtpkrMMOITX+SD5g75Pz0RXqgAAAB4nGNgYoAALgbsgImRiZGZgSnTgIEBAARtALEA) format('woff');font-weight: normal;font-style: normal;}
-
+@font-face { font-family: Hbbe1c; src:url(data:application/x-font-woff;charset=utf-8;base64,d09GRgABAAAAAAVIAAsAAAAAB3gAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAABHU1VCAAABCAAAADsAAABUIIslek9TLzIAAAFEAAAAQAAAAFY240D8Y21hcAAAAYQAAABPAAABfmBD5KlnbHlmAAAB1AAAAaAAAAG0D5MbTmhlYWQAAAN0AAAAMwAAADYVThC6aGhlYQAAA6gAAAAeAAAAJAfRA+hobXR4AAADyAAAAAwAAAAMBsD/+2xvY2EAAAPUAAAACAAAAAgALADabWF4cAAAA9wAAAAfAAAAIAESAIFuYW1lAAAD/AAAASkAAAIWm5e+CnBvc3QAAAUoAAAAIAAAADEDfZw2eJxjYGRgYOBiMGCwY2BycfMJYeDLSSzJY5BiYGGAAJA8MpsxJzM9kYEDxgPKsYBpDiBmg4gCACY7BUgAeJxjYGRyYJzAwMrAwFTFtIeBgaEHQjM+YDBkZAKKMrAyM2AFAWmuKQwODxgeMDK/AHKjgOQRIM0IkgMAzjULTnic7ZCxDYAwDATPiaFAjEFBwTBUzM8mydtmDF66k/7lysACdHEJB3swIrdWy72z5e4ceeOxvzaGTFjd001a+bOnz6+1+FNRnytoE7boCy0AeJxNjT9v01AUxd+xiR2b6L1Ytp/zbDfue1YcIP2DkjYhTtTS0imqBEJdQMDSpSsSqtqpX6ASA3wC1BkmRiYG1IGhEurAABJiQWJAggGBcHDLwnLv75x7dC7RCJl+055rx+QC4YREqLRcUwaSwU8X0UuwCtmWczkqqOYHxVsTWXCkHdk3jTt37eKLjyfa8Z+Hk4n2+PT2z3ksHFxvNHa+E1KZ/p6O9a/65bL1KhmSW+QRIS7vrmIFWXsBBsPZNCl4gLTEDlTppcrwHY/3ZLffdvqZrrKlfpd7Risd9LN/EYOPYBpNDNzyXqGYQZYqCq+J7goGywP/P7nsLGWfrdB6FTmNZri+JlxXrK2HzYYT4fQBNSLn0IkMej9IkgBv+Cww++vKaLQ1HmuHu3M6qz21KCRobX9RZ6L60qTXig88rjOVS5nfyCXes7oaKjXcGKpL2LOs1/HmRPAaF553viabcbEfM89jcRIUP3iScNSCpPh49mRr9GnbrtvVE4s+sxkugtm+9mJeT4MTXXR6HSE64p26d85hyQhnWoT8BXaJUc94nGNgZGBgAGL3oIpb8fw2Xxm4mV8ARRhuKj/bAaP///5vw/yGWRPI5WBgAokCAHr2DhEAeJxjYGRgYH7BwAAi///+/4f5DQMjAypgBgCelAbAAAAAAAAAAtgAAAPo//sAAAAAACwA2nicY2BkYGBgZihlYGUAASYg5gJCBob/YD4DABR7AZQAeJxlkD1uwkAUhMdgSAJSghQpKbNVCiKZn5IDQE9Bl8KYtTGyvdZ6QaLLCXKEHCGniHKCHChj82hgLT9/M2/e7soABviFh3p5uG1qvVq4oTpxm/Qg7JOfhTvo40W4S38o3MMbpsJ9POKdO3j+HZ0BSuEW7vEh3Kb/KeyTv4Q7eMK3cJf+j3APK/wJ9/HqDdPIFLEp3FIn+yy0Z3n+rrStUlOoSTA+WwtdaBs6vVHro6oOydS5WMXW5GrOrs4yo0prdjpywda5cjYaxeIHkcmRIoJBgbipDktoJNgjQwh71b3UK6YtKvq1VpggwPgqtWCqaJIhlcaGyTWOrBUOPG1K1zGt+FrO5KS5zGreJCMr/u+6t6MT0Q+wbaZKzDDiE1/kg+YO+T89EV6oAAAAeJxjYGKAAC4G7ICZkYmRmZGFgSnTgCnTkIEBAAkwAVM=) format('woff');font-weight: normal;font-style: normal;}
 a:before {
   text-rendering: auto;
   -webkit-font-smoothing: antialiased;
   -moz-osx-font-smoothing: grayscale;
-  font-family: Hacc2d;
+  font-family: Hbbe1c;
   font-weight: normal;
   content: '\e000';
   margin-right: 10px;
 }
+a:after {
+  text-rendering: auto;
+  -webkit-font-smoothing: antialiased;
+  -moz-osx-font-smoothing: grayscale;
+  font-family: Hbbe1c;
+  font-weight: normal;
+  content: '\e001';
+  margin-left: 10px;
+}
+
 
 html {
-	background: #1d1f20;
+	background: #ffffff;
 }
 a {
 	font-family: Arial;
@@ -20,13 +29,13 @@ a {
   text-decoration: none;
   color: transparent;
   transition: 0.5s color;
-	background: linear-gradient(92deg, #f35626, #feab3a);
+	background: linear-gradient(92deg, #f35626, #d88e27);
 	background-clip: text;
 	-webkit-background-clip: text;
-	animation: hue 10s infinite linear;
+  animation: hue 10s infinite linear;
 }
 a:hover, a:focus {
-  color: white;
+  color: #333;
 }
 
 @keyframes hue {
diff --git a/example/animation/icons.svg b/example/animation/icons.svg
@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -100 512 512"><path d="M116.65 219.35a15.68 15.68 0 0 0 22.65 0l96.75-99.83c28.15-29 26.5-77.1-4.91-103.88-27.39-23.34-68.14-19.14-93.28 6.8l-9.86 10.14-9.85-10.14c-25.1-25.94-65.9-30.14-93.29-6.8-31.41 26.78-33 74.85-5 103.88zm143.92 100.49h-48l-7.08-14.24a27.39 27.39 0 0 0-25.66-17.78h-71.71a27.39 27.39 0 0 0-25.66 17.78l-7 14.24h-48a27.45 27.45 0 0 0-27.46 27.46v137.25a27.44 27.44 0 0 0 27.43 27.45h233.14a27.45 27.45 0 0 0 27.43-27.45v-137.25a27.45 27.45 0 0 0-27.43-27.46zm-116.57 148.16a52 52 0 1 1 52-52 52 52 0 0 1-52 52zm355.4-115.9h-60.58l22.36-50.75c2.1-6.65-3.93-13.21-12.18-13.21h-75.59c-6.3 0-11.66 3.9-12.5 9.1l-16.8 106.93c-1 6.3 4.88 11.89 12.5 11.89h62.31l-24.2 83c-1.89 6.65 4.2 12.9 12.23 12.9a13.26 13.26 0 0 0 10.92-5.25l92.4-138.91c4.88-6.91-1.16-15.7-10.87-15.7zm-21.32-351.77l-148.57 22.84c-14.64 2.25-25.51 15.75-25.51 31.66v106.77a83.25 83.25 0 0 0-16-1.7c-35.35 0-64 21.48-64 48s28.65 48 64 48c35.2 0 63.73-21.32 64-47.66v-108.58l112-17.22v47.18a83.25 83.25 0 0 0-16-1.7c-35.35 0-64 21.48-64 48s28.65 48 64 48c35.2 0 63.73-21.32 64-47.66v-144.26c0-19.48-16-34.42-33.92-31.67z"/></svg>
diff --git a/example/animation/main.css b/example/animation/main.css
@@ -2,9 +2,14 @@ a:before {
   font-icon: url('./html5.svg');
   margin-right: 10px;
 }
+a:after {
+  font-icon: url('./icons.svg');
+  margin-left: 10px;
+}
+
 
 html {
-	background: #1d1f20;
+	background: #ffffff;
 }
 a {
 	font-family: Arial;
@@ -13,13 +18,13 @@ a {
   text-decoration: none;
   color: transparent;
   transition: 0.5s color;
-	background: linear-gradient(92deg, #f35626, #feab3a);
+	background: linear-gradient(92deg, #f35626, #d88e27);
 	background-clip: text;
 	-webkit-background-clip: text;
-	animation: hue 10s infinite linear;
+  animation: hue 10s infinite linear;
 }
 a:hover, a:focus {
-  color: white;
+  color: #333;
 }
 
 @keyframes hue {
diff --git a/iconfont.gif b/iconfont.gif
diff --git a/lib/icons-to-woff.js b/lib/icons-to-woff.js
@@ -52,10 +52,6 @@ module.exports = function createIconFont (fs, icons, options) {
         }
         // prevent svgs with fill="none" from beeing translated into an empty symbol
         const svgCode = svgBuffer.toString().replace(/\sfill\s*=\s*["']?none['"]?/ig, '');
-        const iconHeight = getSvgHeight(svgCode, filename);
-        if (!iconHeight) {
-          return reject(new Error(`SVG font generation failed as icon "${filename}" does not have a height.`));
-        }
         glyph.push(svgCode);
         glyph.push(null);
       });
@@ -66,18 +62,3 @@ module.exports = function createIconFont (fs, icons, options) {
     .then((ttfFont) => ttf2woff(ttfFont).buffer)
     .then((woffFont) => Buffer.from(woffFont).toString('base64'));
 };
-
-/**
- * Reads the height of the svg
- *
- * @param  {string} svg      the svg content
- * @param  {string} filename the file name for error reporting
- * @return {string}          height
- */
-function getSvgHeight (svg, filename) {
-  const parseSvg = /<svg[^>]+height\s*=\s*["']?(\d+)\s*(pt|px|)["']?/i.exec(svg);
-  if (!parseSvg) {
-    throw new Error(`could not read height for '${filename}'.`);
-  }
-  return parseSvg[1];
-}
