Exception message now contains traceId to request debug information from Tikkie provider

JochemKlingeler · JochemKlingeler · commit 932ad65060f1 · 2018-09-26T22:10:38.000+02:00
diff --git a/README.md b/README.md
@@ -117,5 +117,5 @@ use PHPTikkie\Exceptions\PHPTikkieException;
 try {
     var_dump($tikkie->platforms());
 } catch (PHPTikkieException $exception) {
-    print $exception->getMessage(); // [ERR_2005_002] The API Key is invalid for the requested resource (see https://developer.abnamro.com/get-started#obtaining-an-api-key)
+    print $exception->getMessage(); // [ERR_2005_002] The API Key is invalid for the requested resource | traceId: 6fda2ce8-225d-4ca2-920a-b687c7aeb2f3 | (see https://developer.abnamro.com/get-started#obtaining-an-api-key)
 }
diff --git a/src/Exceptions/PHPTikkieException.php b/src/Exceptions/PHPTikkieException.php
@@ -22,7 +22,9 @@ public function __construct($message, $code = 0, Exception $previous = null)
             if (count($this->errors) > 0) {
                 $error = $this->errors[0];
 
-                $message = "[{$error->code}] {$error->message} (see {$error->reference})";
+                $message = "[{$error->code}] {$error->message} "
+                    . "| traceId: {$error->traceId} | "
+                    . "(see {$error->reference})";
             }
         }
 
diff --git a/tests/CreatePaymentRequestTest.php b/tests/CreatePaymentRequestTest.php
@@ -29,7 +29,7 @@ public function testCreatePaymentRequestFailed()
         $this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);
 
         $this->expectException(RequestException::class);
-        $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");
+        $this->expectExceptionMessage("[ERR_1100_004] Field validation error | traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 | (see https://developer.abnamro.com/api/tikkie/technical-details)");
 
         $this->newPaymentRequest()->save();
     }
diff --git a/tests/CreatePlatformTest.php b/tests/CreatePlatformTest.php
@@ -33,7 +33,7 @@ public function testCreatePlatformFailed()
         $this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);
 
         $this->expectException(RequestException::class);
-        $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");
+        $this->expectExceptionMessage("[ERR_1100_004] Field validation error | traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 | (see https://developer.abnamro.com/api/tikkie/technical-details)");
 
         $this->newPlatform()->save();
     }
diff --git a/tests/CreateUserTest.php b/tests/CreateUserTest.php
@@ -43,7 +43,7 @@ public function testCreateUserFailed()
         $this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);
 
         $this->expectException(RequestException::class);
-        $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");
+        $this->expectExceptionMessage("[ERR_1100_004] Field validation error | traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 | (see https://developer.abnamro.com/api/tikkie/technical-details)");
 
         $this->newUser()->save();
     }
diff --git a/tests/EnvironmentTest.php b/tests/EnvironmentTest.php
@@ -20,7 +20,7 @@ public function testInvalidApiKeyHandling()
         $this->setMockHttpResponse('InvalidApiKey.txt');
 
         $this->expectException(AccessTokenException::class);
-        $this->expectExceptionMessage("[ERR_2005_001] The API Key is invalid (see https://developer.abnamro.com/get-started#obtaining-an-api-key)");
+        $this->expectExceptionMessage("[ERR_2005_001] The API Key is invalid | traceId: 98de8459-377d-4834-a0a2-079f94f0f43d | (see https://developer.abnamro.com/get-started#obtaining-an-api-key)");
 
         $this->tikkie->newPlatform()->save();
     }
diff --git a/tests/FetchPaymentRequestTest.php b/tests/FetchPaymentRequestTest.php
@@ -48,7 +48,7 @@ public function testFetchPaymentRequestFailed()
         $this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);
 
         $this->expectException(RequestException::class);
-        $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");
+        $this->expectExceptionMessage("[ERR_1100_004] Field validation error | traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 | (see https://developer.abnamro.com/api/tikkie/technical-details)");
 
         $this->tikkie->paymentRequest('platformtoken1', 'usertoken1', 'paymentrequesttoken1');
     }
diff --git a/tests/FetchPaymentRequestsTest.php b/tests/FetchPaymentRequestsTest.php
@@ -58,7 +58,7 @@ public function testFetchPaymentRequestsFailed()
         $this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);
 
         $this->expectException(RequestException::class);
-        $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");
+        $this->expectExceptionMessage("[ERR_1100_004] Field validation error | traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 | (see https://developer.abnamro.com/api/tikkie/technical-details)");
 
         $this->tikkie->paymentRequests('platformtoken1', 'usertoken1', 0, 10);
     }
diff --git a/tests/FetchPlatformsTest.php b/tests/FetchPlatformsTest.php
@@ -36,7 +36,7 @@ public function testFetchUsersFailed()
         $this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);
 
         $this->expectException(RequestException::class);
-        $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");
+        $this->expectExceptionMessage("[ERR_1100_004] Field validation error | traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 | (see https://developer.abnamro.com/api/tikkie/technical-details)");
 
         $this->tikkie->platforms();
     }
diff --git a/tests/FetchUsersTest.php b/tests/FetchUsersTest.php
@@ -42,7 +42,7 @@ public function testFetchUsersFailed()
         $this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);
 
         $this->expectException(RequestException::class);
-        $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");
+        $this->expectExceptionMessage("[ERR_1100_004] Field validation error | traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 | (see https://developer.abnamro.com/api/tikkie/technical-details)");
 
         $this->tikkie->users('platformtoken1');
     }

Original file line number	Diff line number	Diff line change
`@@ -117,5 +117,5 @@ use PHPTikkie\Exceptions\PHPTikkieException;`
`117`	`117`	`try {`
`118`	`118`	`var_dump($tikkie->platforms());`
`119`	`119`	`} catch (PHPTikkieException $exception) {`
`120`		`- print $exception->getMessage(); // [ERR_2005_002] The API Key is invalid for the requested resource (see https://developer.abnamro.com/get-started#obtaining-an-api-key)`
	`120`	`+ print $exception->getMessage(); // [ERR_2005_002] The API Key is invalid for the requested resource \| traceId: 6fda2ce8-225d-4ca2-920a-b687c7aeb2f3 \| (see https://developer.abnamro.com/get-started#obtaining-an-api-key)`
`121`	`121`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,9 @@ public function __construct($message, $code = 0, Exception $previous = null)`
`22`	`22`	`if (count($this->errors) > 0) {`
`23`	`23`	`$error = $this->errors[0];`
`24`	`24`
`25`		`- $message = "[{$error->code}] {$error->message} (see {$error->reference})";`
	`25`	`+ $message = "[{$error->code}] {$error->message} "`
	`26`	`+ . "\| traceId: {$error->traceId} \| "`
	`27`	`+ . "(see {$error->reference})";`
`26`	`28`	`}`
`27`	`29`	`}`
`28`	`30`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function testCreatePaymentRequestFailed()`
`29`	`29`	`$this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);`
`30`	`30`
`31`	`31`	`$this->expectException(RequestException::class);`
`32`		`- $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");`
	`32`	`+ $this->expectExceptionMessage("[ERR_1100_004] Field validation error \| traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 \| (see https://developer.abnamro.com/api/tikkie/technical-details)");`
`33`	`33`
`34`	`34`	`$this->newPaymentRequest()->save();`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public function testCreatePlatformFailed()`
`33`	`33`	`$this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);`
`34`	`34`
`35`	`35`	`$this->expectException(RequestException::class);`
`36`		`- $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");`
	`36`	`+ $this->expectExceptionMessage("[ERR_1100_004] Field validation error \| traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 \| (see https://developer.abnamro.com/api/tikkie/technical-details)");`
`37`	`37`
`38`	`38`	`$this->newPlatform()->save();`
`39`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function testCreateUserFailed()`
`43`	`43`	`$this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);`
`44`	`44`
`45`	`45`	`$this->expectException(RequestException::class);`
`46`		`- $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");`
	`46`	`+ $this->expectExceptionMessage("[ERR_1100_004] Field validation error \| traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 \| (see https://developer.abnamro.com/api/tikkie/technical-details)");`
`47`	`47`
`48`	`48`	`$this->newUser()->save();`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public function testInvalidApiKeyHandling()`
`20`	`20`	`$this->setMockHttpResponse('InvalidApiKey.txt');`
`21`	`21`
`22`	`22`	`$this->expectException(AccessTokenException::class);`
`23`		`- $this->expectExceptionMessage("[ERR_2005_001] The API Key is invalid (see https://developer.abnamro.com/get-started#obtaining-an-api-key)");`
	`23`	`+ $this->expectExceptionMessage("[ERR_2005_001] The API Key is invalid \| traceId: 98de8459-377d-4834-a0a2-079f94f0f43d \| (see https://developer.abnamro.com/get-started#obtaining-an-api-key)");`
`24`	`24`
`25`	`25`	`$this->tikkie->newPlatform()->save();`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function testFetchPaymentRequestFailed()`
`48`	`48`	`$this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);`
`49`	`49`
`50`	`50`	`$this->expectException(RequestException::class);`
`51`		`- $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");`
	`51`	`+ $this->expectExceptionMessage("[ERR_1100_004] Field validation error \| traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 \| (see https://developer.abnamro.com/api/tikkie/technical-details)");`
`52`	`52`
`53`	`53`	`$this->tikkie->paymentRequest('platformtoken1', 'usertoken1', 'paymentrequesttoken1');`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public function testFetchPaymentRequestsFailed()`
`58`	`58`	`$this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);`
`59`	`59`
`60`	`60`	`$this->expectException(RequestException::class);`
`61`		`- $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");`
	`61`	`+ $this->expectExceptionMessage("[ERR_1100_004] Field validation error \| traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 \| (see https://developer.abnamro.com/api/tikkie/technical-details)");`
`62`	`62`
`63`	`63`	`$this->tikkie->paymentRequests('platformtoken1', 'usertoken1', 0, 10);`
`64`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function testFetchUsersFailed()`
`36`	`36`	`$this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);`
`37`	`37`
`38`	`38`	`$this->expectException(RequestException::class);`
`39`		`- $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");`
	`39`	`+ $this->expectExceptionMessage("[ERR_1100_004] Field validation error \| traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 \| (see https://developer.abnamro.com/api/tikkie/technical-details)");`
`40`	`40`
`41`	`41`	`$this->tikkie->platforms();`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function testFetchUsersFailed()`
`42`	`42`	`$this->setMockHttpResponse(['AccessToken.txt', 'ValidationError.txt']);`
`43`	`43`
`44`	`44`	`$this->expectException(RequestException::class);`
`45`		`- $this->expectExceptionMessage("[ERR_1100_004] Field validation error (see https://developer.abnamro.com/api/tikkie/technical-details)");`
	`45`	`+ $this->expectExceptionMessage("[ERR_1100_004] Field validation error \| traceId: 3cbf4bc9-108c-4e02-ad6e-937c79d875e3 \| (see https://developer.abnamro.com/api/tikkie/technical-details)");`
`46`	`46`
`47`	`47`	`$this->tikkie->users('platformtoken1');`
`48`	`48`	`}`