Skip to content

Killing coffee process does not kill child node process #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svicalifornia opened this issue Jan 23, 2016 · 1 comment
Closed

Killing coffee process does not kill child node process #4185

svicalifornia opened this issue Jan 23, 2016 · 1 comment

Comments

@svicalifornia
Copy link

See remy/nodemon#195

When running coffee --nodejs ..., a node child process is created.

Killing/restarting the coffee process does not kill the node process and can continue tying up resources that the new process needs to access. For example, if node was started with --debug, then it will keep using port 5858, preventing the newly spawned node process from opening that port.

Workaround is to abandon the coffee command and use:

node --debug ./node_modules/.bin/coffee path/to/script.coffee

However, it seems the coffee command is essentially useless when launching node and working with automated restart workflows.

Proposed solution: coffee should handle SIGINT and SIGTERM and kill any child processes it has started.

@GeoffreyBooth
Copy link
Collaborator

While a fix for this would be welcomed as a PR, the coffee command is not meant to replace the Node runtime. Its primary use is compiling CoffeeScript, and other functions are provided primarily for debugging purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants