Skip to content

FIX : backward test eating unrelated value errors - #42637

Open
Andrewplaez wants to merge 2 commits into
jax-ml:mainfrom
Andrewplaez:fix-mgpu-backward-valueerror
Open

Andrewplaez wants to merge 2 commits into
jax-ml:mainfrom
Andrewplaez:fix-mgpu-backward-valueerror

Conversation

@Andrewplaez

@Andrewplaez Andrewplaez commented Nov 15, 2026 •

Copy link
Copy Markdown

Closes #42614

Summary

The backward pass test in tests/pallas/mgpu_attention_test.py catches
ValueError exceptions to skip configurations that exceed available
shared memory.

However, unrelated ValueError exceptions were silently swallowed,
potentially allowing the test to pass even when the backward computation
failed.

This change re-raises any ValueError that does not match the expected
shared-memory error, ensuring unexpected failures are reported correctly.

Testing

  • Reviewed the exception-handling logic.
  • Unable to run the test locally because the current JAX backend
    does not provide a prebuilt jaxlib wheel for Intel macOS.

AI disclosure

No AI was used all to fix this bug only to review.

@google-cla

google-cla Bot commented Nov 15, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mosaic gpu attention: unchecked shape values and missing test error

1 participant