crossplane: only generate hooks.go once

The crossplane code generation was generating a `zz_hooks.go` file in
each resource subpackage. This was incorrect in two ways: first, the
file should not have been prefixed with `zz_`. Secondly, there only
needs to be a single `pkg/controller/$SERVICE/$RESOURCE/hooks.go` file
generated, not one per resource.

This PR simply moves the generation of the `hooks.go` template out of
the loop over CRDs inside the crossplane TemplateSet constructor and
ensures that a single hooks.go file is generated from the first CRD's
structure.

Also removes unncessary templates that crossplane doesn't use and
corrects a mistake in the hooks.go.tpl for the ReadMany code path's
isUpToDate() function.

Author: jaypipes

cmd/ack-generate/command/crossplane.go

@@ -99,8 +99,8 @@ func generateCrossplane(_ *cobra.Command, args []string) error {
 			return err
 		}
 	}
-	apiPath := filepath.Join(providerDir, "apis", optGenVersion)
-	controllerPath := filepath.Join(providerDir, "pkg", "controller")
+	apiPath := filepath.Join(providerDir, "apis", svcAlias, optGenVersion)
+	controllerPath := filepath.Join(providerDir, "pkg", "controller", svcAlias)
 	// TODO(muvaf): goimports don't allow to be included as a library. Make sure
 	// goimports binary exists.
 	if err := exec.Command("goimports", "-w", apiPath, controllerPath).Run(); err != nil {

pkg/generate/crossplane/crossplane.go

@@ -152,7 +152,6 @@ func Crossplane(
 	targets := []string{
 		"controller.go.tpl",
 		"conversions.go.tpl",
-		"hooks.go.tpl",
 	}
 	for _, crd := range crds {
 		for _, target := range targets {
@@ -169,5 +168,21 @@ func Crossplane(
 			}
 		}
 	}
+
+	// Finally, generate the single hooks.go file from one of the CRDs (doesn't
+	// matter which since the hooks.go is generic for all CRs)
+	crd := crds[0]
+	outPath := filepath.Join(
+		"pkg", "controller", metaVars.ServiceIDClean, crd.Names.Snake,
+		"hooks.go",
+	)
+	crdVars := &templateCRDVars{
+		metaVars,
+		crd,
+	}
+	if err = ts.Add(outPath, "pkg/hooks.go.tpl", crdVars); err != nil {
+		return nil, err
+	}
+
 	return ts, nil
 }