Lint activate.ps1

Fix PSScriptAnalyzer warnings, and follow style from
-Setting CodeFormattingOTBS

Closes pypa#1371

Author: jayvdb

docs/changelog/1371.feature.rst

@@ -0,0 +1 @@
+``activate.ps1`` syntax and style updated to follow ``PSStyleAnalyzer`` rules

virtualenv.py

@@ -2372,18 +2372,19 @@ def convert(s):
 # file activate.ps1
 ACTIVATE_PS = convert(
     """
-eJytVcFu2zAMvfsrWNfYEmx2sWuGHVIkQAO0adBkvWyDoMh0I0CWDElOGwz598p2HDt20w3YdLP5
-SD2Sj9QlrDbcQMIFQpobC2uEWFkwKtcMY0i0SmGhlpuvsFM5MCqls+pcArcQc43Mil0EEwXWxRlB
-BNEVZZZvqcUoM188LzBM88yOVjezJVmMVzfwDYJ0x+VWMWq5klG6YypNqYyjjNrN0eF6vJySyezB
-4U0muA0LKww0GiW2WH35wTHsVRT5QwgXVKO0npfkkhXR4UmoNRWjGGtagx/mmVu2+QXBXMkJGqvz
-woRD77cH7vAEBtb9rq7YUs3pWuCI3N9OyOPsYfV9fFveOCzRlU9xApTbUZ3hebcjXmOqXCI1Evwe
-1IfQMJXhIYnSc++9QbLOdkSUiMmWa5tTQTLXvMz2aB7Blb1g+55/ly+3mDYX/jzn0eJZFqbOazp/
-7DEqQjjMaae7XhAKpMmbbHpI1FppWgnAOG1Lp1KmpOUyxy67i54MTtldwhJFAvEBcfF+PRqdvY/L
-drFiByr7vlwrc0Ui29mNs4QplH8hoPrJFE6XkEuDFrjWKHBLpT2q1XgNEQilknGToJvJdrFc++tR
-83o1d8bWp/M88OtJtUDW+vfak+B3Y14Rcj2bk/n4bkrcKWBkOV0Q4sOnVoyqNR1fR3I5vr6dksXD
-/d1iVU9st3rnNNk01fcPtT+diDccT8ajFavg55OmBiWhIolQulH2uyrqNfh0thpgJblxHLuNisDc
-TnYbONOY8BewqvyJL9w4KT9BJ0hxnrXTWbhRbpWfYackPgsu8cTtw1/ugH2rbCgM/nuWtJMcy3Wx
-wQ+5fYZ17h4aJT8Wz41hVMfu5YnOpjwIBn/eITAcwn+rxN57BRHvOEk=
+eJytVV1v2jAUfc+vuE2jDdQl1V6Z+kAHUpEoRYT1ZZssk9wUS4kd2U5aNPHf53xAQgJVNc1v9v3w
+Ofeea1/DessURCxGSDKlYYMQCg1KZDLAECIpElgKf/sNdiKDgHJurDLjwDSETGKg450HEwHa5BmB
+B94tDTTLqUYvVV8ty1GBZKkerR9mPlmO1w9wB06yYzwXAdVMcC/ZBSJJKA+9lOrtMeB+7E/JZLYy
+/n4aM+0ujRUGK1QizrHa2c4x7a3n2UMwxxK5tqwo40GRHV5isaHxKMQDrMFP9cp0sP0NzkLwCSot
+s8KEQ/hjgVksgsHaHFdX5FQyuolxRJ7mE/I8W61/jOfljQf/YjnI89GB3eWQo/8KE2FIPNeeYPdc
+bXD9QKRYEygj99YZgAemIyLikORM6ozGJDWNS/UJxKNjZSuQvhfbxTrTmDSX/boU0cJYFuXAabp4
+bqNpJ+24gTuVUshx1T/fSJMbkX0XXDOeYfeSqwtdLNY1+BhHENbWq/cpNRJ53y/dhSKoYez7SivN
+NYh0p7fG4iZQnTpUvqgi6BoyrlADkxJjzCnXR6EpqwECLhc8bMiZcWoXynTwMCVWt9iFsbW1rAW+
+Nno70Ra4C5og9CQIxj/OsBG3ZbV1bnevvCXkfrYgi/HjlJhVuBF/uiTEhptWkqprnVjDwR/fz6dk
+uXp6XK4PXewW94zqWv227botp3o/F3TXm4dGUjZpylCiKRi43Eyp3VZXr/FdOJUEx2FoHkeEwDyv
+5jFNJUbsDbQoD/GNKSPrF+jMXEnAuOZMZKrGTPKyG3fw6YODW6zzZG4uJB8eY6sa7gFjhf/GmXao
+Bpksnuaa6RfYZOYHEfxz8Y+ogMrQfCne/y+Aw/G1G28PnEH7U+nNjjtHGsFwCPZpMfvJPlxJM/V/
+AZYlUQw=
 """
 )
 

virtualenv_embedded/activate.ps1

@@ -1,38 +1,31 @@
 # This file must be dot sourced from PoSh; you cannot run it directly. Do this: . ./activate.ps1
 
 $script:THIS_PATH = $myinvocation.mycommand.path
-$script:BASE_DIR = split-path (resolve-path "$THIS_PATH/..") -Parent
+$script:BASE_DIR = Split-Path (Resolve-Path "$THIS_PATH/..") -Parent
 
-function global:deactivate([switch] $NonDestructive)
-{
-    if (test-path variable:_OLD_VIRTUAL_PATH)
-    {
+function global:deactivate([switch] $NonDestructive) {
+    if (Test-Path variable:_OLD_VIRTUAL_PATH) {
         $env:PATH = $variable:_OLD_VIRTUAL_PATH
-        remove-variable "_OLD_VIRTUAL_PATH" -scope global
+        Remove-Variable "_OLD_VIRTUAL_PATH" -Scope global
     }
 
-    if (test-path function:_old_virtual_prompt)
-    {
+    if (Test-Path function:_old_virtual_prompt) {
         $function:prompt = $function:_old_virtual_prompt
-        remove-item function:\_old_virtual_prompt
+        Remove-Item function:\_old_virtual_prompt
     }
 
-    if ($env:VIRTUAL_ENV)
-    {
-        $old_env = split-path $env:VIRTUAL_ENV -leaf
-        remove-item env:VIRTUAL_ENV -erroraction silentlycontinue
+    if ($env:VIRTUAL_ENV) {
+        Remove-Item env:VIRTUAL_ENV -ErrorAction SilentlyContinue
     }
 
-    if (!$NonDestructive)
-    {
+    if (!$NonDestructive) {
         # Self destruct!
-        remove-item function:deactivate
-        remove-item function:pydoc
+        Remove-Item function:deactivate
+        Remove-Item function:pydoc
     }
 }
 
-function global:pydoc
-{
+function global:pydoc {
     python -m pydoc $args
 }
 
@@ -42,31 +35,28 @@ deactivate -nondestructive
 $VIRTUAL_ENV = $BASE_DIR
 $env:VIRTUAL_ENV = $VIRTUAL_ENV
 
-$global:_OLD_VIRTUAL_PATH = $env:PATH
+New-Variable -Scope global -Name _OLD_VIRTUAL_PATH -Value $env:PATH
+
 $env:PATH = "$env:VIRTUAL_ENV/__BIN_NAME____PATH_SEP__" + $env:PATH
-if (!$env:VIRTUAL_ENV_DISABLE_PROMPT)
-{
-    function global:_old_virtual_prompt
-    {
+if (!$env:VIRTUAL_ENV_DISABLE_PROMPT) {
+    function global:_old_virtual_prompt {
         ""
     }
     $function:_old_virtual_prompt = $function:prompt
-    if ("__VIRTUAL_PROMPT__" -ne "")
-    {
-        function global:prompt
-        {
+
+    if ("__VIRTUAL_PROMPT__" -ne "") {
+        function global:prompt {
             # Add the custom prefix to the existing prompt
-            write-host "__VIRTUAL_PROMPT__" -nonewline
-            & $function:_old_virtual_prompt
+            $previous_prompt_value = & $function:_old_virtual_prompt
+            ("__VIRTUAL_PROMPT__" + $previous_prompt_value)
         }
     }
-    else
-    {
-        function global:prompt
-        {
+    else {
+        function global:prompt {
             # Add a prefix to the current prompt, but don't discard it.
-            write-host "($( split-path $env:VIRTUAL_ENV -leaf )) " -nonewline
-            & $function:_old_virtual_prompt
+            $previous_prompt_value = & $function:_old_virtual_prompt
+            $new_prompt_value = "($( Split-Path $env:VIRTUAL_ENV -Leaf )) "
+            ($new_prompt_value + $previous_prompt_value)
         }
     }
 }